Commit fcba92fd authored by tsepez@chromium.org's avatar tsepez@chromium.org

Drag start unexpectedly cancelled. Must always initiate a drag, avoiding

the "optimization" of not doing so when no targets are apparent, otherwise
we break draggable list elements.

BUG=69857
TEST=Manually try dragging <li draggable="true">AAA</li> on linux.

Review URL: http://codereview.chromium.org/6369004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71696 0039d316-1c4b-4281-b951-d872f2087c98
parent c4ad162e
......@@ -100,12 +100,8 @@ void TabContentsDragSource::StartDragging(const WebDropData& drop_data,
targets_mask |= gtk_dnd_util::DIRECT_SAVE_FILE;
}
// Short-circuit execution if no targets present.
if (targets_mask == 0) {
if (tab_contents()->render_view_host())
tab_contents()->render_view_host()->DragSourceSystemDragEnded();
return;
}
// NOTE: Begin a drag even if no targets present. Otherwise, things like
// draggable list elements will not work.
drop_data_.reset(new WebDropData(drop_data));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment