[ChromeDriver] Set error status in repsonse

Added status for every spec error code we currently use

spec: https://w3c.github.io/webdriver/webdriver-spec.html#dfn-error-code

Bug: chromedriver:2046
Change-Id: I36d7ee12859643b76133d342021015e7353f28cc
Reviewed-on: https://chromium-review.googlesource.com/687808Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505239}

chrome/test/chromedriver/server/http_handler.cc

@@ -702,40 +702,83 @@ HttpHandler::PrepareStandardResponse(
     case kOk:
       response.reset(new net::HttpServerResponseInfo(net::HTTP_OK));
       break;
-    case kNoSuchFrame:
-    case kStaleElementReference:
-    case kElementNotVisible:
-    case kInvalidElementState:
-    case kNoSuchWindow:
+    // error codes
+    case kElementNotInteractable:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
+      break;
+    case kInvalidArgument:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
+      break;
     case kInvalidCookieDomain:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
+      break;
+    case kInvalidElementState:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
+      break;
     case kInvalidSelector:
-    case kXPathLookupError:
-    case kNoAlertOpen:
-    case kInvalidArgument:
-    case kElementNotInteractable:
-    case kNoSuchExecutionContext:
       response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
       break;
-    case kNoSuchSession:
-    case kNoSuchElement:
-    case kUnknownCommand:
+    case kJavaScriptError:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
+      break;
     case kNoSuchCookie:
       response.reset(new net::HttpServerResponseInfo(net::HTTP_NOT_FOUND));
       break;
-    case kTimeout:
+    case kNoSuchElement:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_NOT_FOUND));
+      break;
+    case kNoSuchFrame:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_NOT_FOUND));
+      break;
+    case kNoSuchWindow:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_NOT_FOUND));
+      break;
     case kScriptTimeout:
       response.reset(
           new net::HttpServerResponseInfo(net::HTTP_REQUEST_TIMEOUT));
       break;
-    case kUnknownError:
+    case kSessionNotCreatedException:
+      response.reset(
+          new net::HttpServerResponseInfo(net::HTTP_INTERNAL_SERVER_ERROR));
+      break;
+    case kStaleElementReference:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_NOT_FOUND));
+      break;
+    case kTimeout:
+      response.reset(
+          new net::HttpServerResponseInfo(net::HTTP_REQUEST_TIMEOUT));
+      break;
     case kUnableToSetCookie:
-    case kJavaScriptError:
+      response.reset(
+          new net::HttpServerResponseInfo(net::HTTP_INTERNAL_SERVER_ERROR));
+      break;
     case kUnexpectedAlertOpen:
-    case kSessionNotCreatedException:
+      response.reset(
+          new net::HttpServerResponseInfo(net::HTTP_INTERNAL_SERVER_ERROR));
+      break;
+    case kUnknownCommand:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_NOT_FOUND));
+      break;
+    case kUnknownError:
+      response.reset(
+          new net::HttpServerResponseInfo(net::HTTP_INTERNAL_SERVER_ERROR));
+      break;
+    case kUnsupportedOperation:
+      response.reset(
+          new net::HttpServerResponseInfo(net::HTTP_INTERNAL_SERVER_ERROR));
+      break;
+
+    // TODO(kereliuk): evaluate the usage of these as they relate to the spec
+    case kElementNotVisible:
+    case kXPathLookupError:
+    case kNoAlertOpen:
+    case kNoSuchExecutionContext:
+      response.reset(new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));
+      break;
+    case kNoSuchSession:
     case kChromeNotReachable:
     case kDisconnected:
     case kForbidden:
-    case kUnsupportedOperation:
     case kTabCrashed:
       response.reset(
           new net::HttpServerResponseInfo(net::HTTP_INTERNAL_SERVER_ERROR));