[Passwords] Fixed form comparison in SavedPasswordsPresenter::EditPassword

This change fixes android credential password editing on iOS.

Bug: 1134065

Change-Id: I65241882e2dcc0c99425639d20b4b8e0d2150a4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442613
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813535}

components/password_manager/core/browser/ui/saved_passwords_presenter.cc

@@ -41,7 +41,10 @@ void SavedPasswordsPresenter::Init() {
 
 bool SavedPasswordsPresenter::EditPassword(const PasswordForm& form,
                                            base::string16 new_password) {
-  auto found = base::ranges::find(passwords_, form);
+  auto is_equal = [&form](const PasswordForm& form_to_check) {
+    return ArePasswordFormUniqueKeysEqual(form, form_to_check);
+  };
+  auto found = base::ranges::find_if(passwords_, is_equal);
   if (found == passwords_.end())
     return false;
 

components/password_manager/core/browser/ui/saved_passwords_presenter_unittest.cc

@@ -142,6 +142,7 @@ TEST_F(SavedPasswordsPresenterTest, EditPassword) {
 
   // Verify that editing a password that does not exist does not triggers
   // notifications.
+  form.username_value = base::ASCIIToUTF16("another_username");
   EXPECT_CALL(observer, OnEdited).Times(0);
   EXPECT_CALL(observer, OnSavedPasswordsChanged).Times(0);
   EXPECT_FALSE(presenter().EditPassword(form, new_password));