Commit fcfbeb41 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

[WebSocket] Add some CHECKs to investigate crashes

Bug: 999235
Change-Id: I20987927f65a36f0d82bd834b1b8f0b4c24f0ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824047
Commit-Queue: Adam Rice <ricea@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: default avatarAdam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699771}
parent fe60ab10
...@@ -597,6 +597,8 @@ ChannelState WebSocketChannel::ReadFrames() { ...@@ -597,6 +597,8 @@ ChannelState WebSocketChannel::ReadFrames() {
ignore_result(RespondToClosingHandshake()); ignore_result(RespondToClosingHandshake());
} }
// TODO(crbug.com/999235): Remove this CHECK.
CHECK(event_interface_);
while (!event_interface_->HasPendingDataFrames()) { while (!event_interface_->HasPendingDataFrames()) {
DCHECK(stream_); DCHECK(stream_);
// This use of base::Unretained is safe because this object owns the // This use of base::Unretained is safe because this object owns the
...@@ -614,6 +616,8 @@ ChannelState WebSocketChannel::ReadFrames() { ...@@ -614,6 +616,8 @@ ChannelState WebSocketChannel::ReadFrames() {
return CHANNEL_DELETED; return CHANNEL_DELETED;
} }
DCHECK_NE(CLOSED, state_); DCHECK_NE(CLOSED, state_);
// TODO(crbug.com/999235): Remove this CHECK.
CHECK(event_interface_);
} }
return CHANNEL_ALIVE; return CHANNEL_ALIVE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment