Catch uncaught promise rejections from V8 and log to console.

Print error messages to DevTools console for rejected Promises that are unhandled by the platform end-of-turn.

BUG=393913
R=pfeldman, yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183464

Review URL: https://codereview.chromium.org/625943002

git-svn-id: svn://svn.chromium.org/blink/trunk@183598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/fast/css/fontfaceset-multiple-faces-download-error.html

@@ -24,7 +24,7 @@ function runTests() {
     document.fonts.addEventListener('loadingerror', onLoadingError);
     document.fonts.ready().then(finish);
 
-    document.fonts.load('10px TestFont', 'abc');
+    document.fonts.load('10px TestFont', 'abc').catch(function() {});
 }
 
 var event;

third_party/WebKit/LayoutTests/fast/css/fontfaceset-multiple-families.html

@@ -34,7 +34,7 @@ function runTests() {
     document.fonts.addEventListener('loadingerror', onLoadingError);
     document.fonts.ready().then(finish);
 
-    document.fonts.load('10px TestFont1, TestFont2, TestFont3, TestFont4', 'abc');
+    document.fonts.load('10px TestFont1, TestFont2, TestFont3, TestFont4', 'abc').catch(function() {});
 }
 
 var event;

third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

@@ -73,6 +73,11 @@ InspectorTest.fixConsoleViewportDimensions = function(width, height)
 }
 
 InspectorTest.dumpConsoleMessages = function(printOriginatingCommand, dumpClassNames, formatter)
+{
+    InspectorTest.addResults(InspectorTest.dumpConsoleMessagesIntoArray(printOriginatingCommand, dumpClassNames, formatter));
+}
+
+InspectorTest.dumpConsoleMessagesIntoArray = function(printOriginatingCommand, dumpClassNames, formatter)
 {
     formatter = formatter || InspectorTest.prepareConsoleMessageText;
     var result = [];
@@ -94,21 +99,21 @@ InspectorTest.dumpConsoleMessages = function(printOriginatingCommand, dumpClassN
             }
         }
 
-        if (InspectorTest.dumpConsoleTableMessage(uiMessage, false)) {
+        if (InspectorTest.dumpConsoleTableMessage(uiMessage, false, result)) {
             if (dumpClassNames)
-                InspectorTest.addResult(classNames.join(" > "));
+                result.push(classNames.join(" > "));
         } else {
             var messageText = formatter(element, message);
-            InspectorTest.addResult(messageText + (dumpClassNames ? " " + classNames.join(" > ") : ""));
+            result.push(messageText + (dumpClassNames ? " " + classNames.join(" > ") : ""));
         }
 
         if (printOriginatingCommand && uiMessage.consoleMessage().originatingMessage())
-            InspectorTest.addResult("Originating from: " + uiMessage.consoleMessage().originatingMessage().messageText);
+            result.push("Originating from: " + uiMessage.consoleMessage().originatingMessage().messageText);
     }
     return result;
 }
 
-InspectorTest.dumpConsoleTableMessage = function(viewMessage, forceInvalidate)
+InspectorTest.dumpConsoleTableMessage = function(viewMessage, forceInvalidate, results)
 {
     if (forceInvalidate)
         WebInspector.ConsolePanel._view()._viewport.invalidate();
@@ -121,7 +126,7 @@ InspectorTest.dumpConsoleTableMessage = function(viewMessage, forceInvalidate)
     for (var i = 0; i < headers.length; i++)
         headerLine += headers[i].textContent + " | ";
 
-    InspectorTest.addResult("HEADER " + headerLine);
+    addResult("HEADER " + headerLine);
 
     var rows = table.querySelectorAll(".data-container tr");
 
@@ -133,8 +138,17 @@ InspectorTest.dumpConsoleTableMessage = function(viewMessage, forceInvalidate)
             rowLine += items[j].textContent + " | ";
 
         if (rowLine.trim())
-            InspectorTest.addResult("ROW " + rowLine);
+            addResult("ROW " + rowLine);
+    }
+
+    function addResult(x)
+    {
+        if (results)
+            results.push(x);
+        else
+            InspectorTest.addResult(x);
     }
+
     return true;
 }
 

third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

@@ -255,7 +255,7 @@ function test_login(test, origin, username, password) {
         .then(test.step_func(function(frame) {
             var channel = new MessageChannel();
             channel.port1.onmessage = test.step_func(function() {
-                unload_iframe(frame);
+                unload_iframe(frame).catch(function() {});
                 resolve();
               });
             frame.contentWindow.postMessage(

third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html

@@ -50,8 +50,11 @@ function onload()
     bigmap.set(42, 42);
     bigmap.set({foo:"from"}, {foo:"to"});
 
+    var p = Promise.reject(-0);
+    p.catch(function() {});
+
     globals = [
-        Promise.reject(-0), smb1, smb2, obj, map, weakMap, set, weakSet,
+        p, smb1, smb2, obj, map, weakMap, set, weakSet,
         mapMap0, mapMap, setSet0, setSet, bigmap
     ];
 

third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt

+CONSOLE ERROR: Unhandled promise rejection
+CONSOLE ERROR: Unhandled promise rejection
+CONSOLE ERROR: Unhandled promise rejection
+CONSOLE ERROR: Unhandled promise rejection
+Tests that uncaught promise rejections are logged into console.
+
+Unhandled promise rejection Promise
+    __proto__: Promise
+    [[PromiseStatus]]: "rejected"
+    [[PromiseValue]]: Error: onload.err1
+Unhandled promise rejection Promise
+    __proto__: Promise
+    [[PromiseStatus]]: "rejected"
+    [[PromiseValue]]: Error: onload.err2
+Unhandled promise rejection Promise {[[PromiseStatus]]: "rejected", [[PromiseValue]]: Error: inspector.err1}
+    __proto__: Promise
+    [[PromiseStatus]]: "rejected"
+    [[PromiseValue]]: Error: inspector.err1
+Unhandled promise rejection Promise {[[PromiseStatus]]: "rejected", [[PromiseValue]]: Error: inspector.err2}
+    __proto__: Promise
+    [[PromiseStatus]]: "rejected"
+    [[PromiseValue]]: Error: inspector.err2
+

third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise.html

+<html>
+<head>
+<script src="../../http/tests/inspector/inspector-test.js"></script>
+<script src="../../http/tests/inspector/console-test.js"></script>
+<script>
+
+function runPromises(source)
+{
+    Promise.reject(new Error(source + ".err1"))
+        .then()
+        .then()
+        .then(); // Last is unhandled.
+
+    var reject
+    var m0 = new Promise(function(res, rej) { reject = rej; });
+    var m1 = m0.then(function() {});
+    var m2 = m0.then(function() {});
+    var m3 = m0.then(function() {});
+    var m4 = 0;
+    m0.catch(function() {
+        m2.catch(function() {
+            m1.catch(function() {
+                m4 = m3.then(function() {}); // Unhandled.
+            });
+        });
+    });
+    reject(new Error(source + ".err2"));
+}
+
+function onload()
+{
+    runPromises("onload");
+    runTest();
+}
+
+function test()
+{
+    InspectorTest.addConsoleViewSniffer(addMessage, true);
+
+    WebInspector.console.showPromise().then(function() {
+        InspectorTest.evaluateInPage("runPromises('inspector')");
+    });
+
+    var count = 0;
+    function addMessage(uiMessage)
+    {
+        if (uiMessage.toString().indexOf("inspector.err") !== -1)
+            ++count;
+        if (count === 2)
+            InspectorTest.expandConsoleMessages(dump);
+    }
+
+    function dump()
+    {
+        // Sort console messages from async Promises to avoid flakiness.
+        var results = InspectorTest.dumpConsoleMessagesIntoArray(false, false, InspectorTest.textContentWithLineBreaks);
+        results.sort();
+        InspectorTest.addResults(results);
+        InspectorTest.completeTest();
+    }
+}
+
+</script>
+</head>
+
+<body onload="onload()">
+<p>
+Tests that uncaught promise rejections are logged into console.
+</p>
+
+</body>
+</html>

third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt

+CONSOLE ERROR: Unhandled promise rejection
+CONSOLE ERROR: Unhandled promise rejection
+Tests uncaught promise rejections fired during pause.
+
+Set timer for test function.
+debugger-uncaught-promise-on-pause.html:10 Console was cleared
+Unhandled promise rejection Promise {[[PromiseStatus]]: "rejected", [[PromiseValue]]: Error: inspector.err1}
+    __proto__: Promise
+    [[PromiseStatus]]: "rejected"
+    [[PromiseValue]]: Error: inspector.err1
+Unhandled promise rejection Promise {[[PromiseStatus]]: "rejected", [[PromiseValue]]: Error: inspector.err2}
+    __proto__: Promise
+    [[PromiseStatus]]: "rejected"
+    [[PromiseValue]]: Error: inspector.err2
+

third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause.html

+<html>
+<head>
+<script src="../../../http/tests/inspector/inspector-test.js"></script>
+<script src="../../../http/tests/inspector/console-test.js"></script>
+<script src="../../../http/tests/inspector/debugger-test.js"></script>
+<script>
+
+function testFunction()
+{
+    console.clear();
+    debugger;
+}
+
+function runPromises(source)
+{
+    Promise.reject(new Error(source + ".err1"))
+        .then()
+        .then()
+        .then(); // Last is unhandled.
+
+    var reject
+    var m0 = new Promise(function(res, rej) { reject = rej; });
+    var m1 = m0.then(function() {});
+    var m2 = m0.then(function() {});
+    var m3 = m0.then(function() {});
+    var m4 = 0;
+    m0.catch(function() {
+        m2.catch(function() {
+            m1.catch(function() {
+                m4 = m3.then(function() {}); // Unhandled.
+            });
+        });
+    });
+    reject(new Error(source + ".err2"));
+}
+
+function test()
+{
+    InspectorTest.setQuiet(true);
+    InspectorTest.startDebuggerTest(step1);
+
+    function step1()
+    {
+        InspectorTest.addConsoleViewSniffer(addMessage, true);
+        InspectorTest.runTestFunctionAndWaitUntilPaused(didPause);
+    }
+
+    function didPause(callFrames, reason, breakpointIds, asyncStackTrace)
+    {
+        InspectorTest.evaluateInPage("runPromises('inspector')", resumeExecution);
+    }
+
+    function resumeExecution()
+    {
+        InspectorTest.resumeExecution();
+    }
+
+    var count = 0;
+    function addMessage(uiMessage)
+    {
+        if (uiMessage.toString().indexOf("inspector.err") !== -1)
+            ++count;
+        if (count === 2)
+            InspectorTest.expandConsoleMessages(dump);
+    }
+
+    function dump()
+    {
+        InspectorTest.dumpConsoleMessages(false, false, InspectorTest.textContentWithLineBreaks);
+        InspectorTest.completeTest();
+    }
+}
+
+</script>
+</head>
+
+<body onload="runTest()">
+<p>
+Tests uncaught promise rejections fired during pause.
+</p>
+
+</body>
+</html>

third_party/WebKit/LayoutTests/inspector/sources/debugger/event-listener-breakpoints-promises.html

@@ -18,7 +18,7 @@ function testFunction()
     var q = new Promise(function(res, rej) {
         reject = rej;
     });
-    q.then(function() {
+    q.catch(function() {
     });
 
     resolve(42);

third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -30,6 +30,7 @@
 #include "bindings/core/v8/ScriptCallStackFactory.h"
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/ScriptProfiler.h"
+#include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8DOMException.h"
 #include "bindings/core/v8/V8ErrorEvent.h"
@@ -45,6 +46,8 @@
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
+#include "core/inspector/ConsoleMessage.h"
+#include "core/inspector/ScriptArguments.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "platform/EventDispatchForbiddenScope.h"
 #include "platform/TraceEvent.h"
@@ -155,6 +158,78 @@ static void messageHandlerInMainThread(v8::Handle<v8::Message> message, v8::Hand
     }
 }
 
+typedef WillBeHeapDeque<ScriptValue> PromiseRejectMessageQueue;
+
+static PromiseRejectMessageQueue& promiseRejectMessageQueue()
+{
+    DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<PromiseRejectMessageQueue>, queue, (adoptPtrWillBeNoop(new PromiseRejectMessageQueue())));
+    return *queue;
+}
+
+void V8Initializer::reportRejectedPromises()
+{
+    ASSERT(isMainThread());
+
+    PromiseRejectMessageQueue& queue = promiseRejectMessageQueue();
+    while (!queue.isEmpty()) {
+        ScriptValue promise = queue.takeFirst();
+        ScriptState* scriptState = promise.scriptState();
+        if (!scriptState->contextIsValid())
+            continue;
+        ScriptState::Scope scope(scriptState);
+
+        ASSERT(!promise.isEmpty());
+        v8::Handle<v8::Value> value = promise.v8Value();
+        ASSERT(!value.IsEmpty() && value->IsPromise());
+        if (v8::Handle<v8::Promise>::Cast(value)->HasHandler())
+            continue;
+
+        ExecutionContext* executionContext = scriptState->executionContext();
+        if (!executionContext)
+            continue;
+
+        const String errorMessage = "Unhandled promise rejection";
+        Vector<ScriptValue> args;
+        args.append(ScriptValue(scriptState, v8String(scriptState->isolate(), errorMessage)));
+        args.append(promise);
+        RefPtrWillBeRawPtr<ScriptArguments> arguments = ScriptArguments::create(scriptState, args);
+
+        RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage, "", 0);
+        consoleMessage->setScriptArguments(arguments);
+        executionContext->addConsoleMessage(consoleMessage.release());
+    }
+}
+
+static void promiseRejectHandlerInMainThread(v8::PromiseRejectMessage message)
+{
+    ASSERT(isMainThread());
+
+    if (message.GetEvent() != v8::kPromiseRejectWithNoHandler)
+        return;
+
+    // It's possible that promiseRejectHandlerInMainThread() is invoked while we're initializing a window.
+    // In that half-baked situation, we don't have a valid context nor a valid world,
+    // so just return immediately.
+    if (DOMWrapperWorld::windowIsBeingInitialized())
+        return;
+
+    v8::Handle<v8::Promise> promise = message.GetPromise();
+
+    // Bail out if called during context initialization.
+    v8::Isolate* isolate = promise->GetIsolate();
+    v8::Handle<v8::Context> context = isolate->GetCurrentContext();
+    if (context.IsEmpty())
+        return;
+    v8::Handle<v8::Value> global = V8Window::findInstanceInPrototypeChain(context->Global(), context->GetIsolate());
+    if (global.IsEmpty())
+        return;
+    if (!toFrameIfNotDetached(context))
+        return;
+
+    ScriptState* scriptState = ScriptState::from(context);
+    promiseRejectMessageQueue().append(ScriptValue(scriptState, promise));
+}
+
 static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8::AccessType type, v8::Local<v8::Value> data)
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
@@ -218,6 +293,7 @@ void V8Initializer::initializeMainThreadIfNeeded()
     v8::V8::SetAllowCodeGenerationFromStringsCallback(codeGenerationCheckCallbackInMainThread);
 
     isolate->SetEventLogger(timerTraceProfilerInMainThread);
+    isolate->SetPromiseRejectCallback(promiseRejectHandlerInMainThread);
 
     ScriptProfiler::initialize();
 }

third_party/WebKit/Source/bindings/core/v8/V8Initializer.h

@@ -34,6 +34,7 @@ class V8Initializer {
 public:
     static void initializeMainThreadIfNeeded();
     static void initializeWorker(v8::Isolate*);
+    static void reportRejectedPromises();
 };
 
 } // namespace blink

third_party/WebKit/Source/web/WebKit.cpp

@@ -78,6 +78,7 @@ public:
     {
         Microtask::performCheckpoint();
         V8GCController::reportDOMMemoryUsageToV8(mainThreadIsolate());
+        V8Initializer::reportRejectedPromises();
     }
 };