WebApp:Convert standalone friend == method into class method.

Change-Id: I92b855f231ede21d1263b4147d895864e7961268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536651
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827160}

chrome/browser/web_applications/web_app.cc

@@ -378,7 +378,7 @@ bool operator!=(const WebApp::SyncFallbackData& sync_fallback_data1,
   return !(sync_fallback_data1 == sync_fallback_data2);
 }
 
-bool operator==(const WebApp& app1, const WebApp& app2) {
+bool WebApp::operator==(const WebApp& other) const {
   auto AsTuple = [](const WebApp& app) {
     // Keep in order declared in web_app.h.
     return std::tie(
@@ -420,11 +420,11 @@ bool operator==(const WebApp& app1, const WebApp& app2) {
         // clang-format on
     );
   };
-  return AsTuple(app1) == AsTuple(app2);
+  return AsTuple(*this) == AsTuple(other);
 }
 
-bool operator!=(const WebApp& app1, const WebApp& app2) {
-  return !(app1 == app2);
+bool WebApp::operator!=(const WebApp& other) const {
+  return !(*this == other);
 }
 
 }  // namespace web_app

chrome/browser/web_applications/web_app.h

@@ -212,12 +212,15 @@ class WebApp {
   void SetRunOnOsLoginMode(RunOnOsLoginMode mode);
   void SetSyncFallbackData(SyncFallbackData sync_fallback_data);
 
+  // For logging and debug purposes.
+  bool operator==(const WebApp&) const;
+  bool operator!=(const WebApp&) const;
+
  private:
   using Sources = std::bitset<Source::kMaxValue + 1>;
   bool HasAnySpecifiedSourcesAndNoOtherSources(Sources specified_sources) const;
 
   friend class WebAppDatabase;
-  friend bool operator==(const WebApp&, const WebApp&);
   friend std::ostream& operator<<(std::ostream&, const WebApp&);
 
   AppId app_id_;
@@ -272,9 +275,6 @@ bool operator==(const WebApp::SyncFallbackData& sync_fallback_data1,
 bool operator!=(const WebApp::SyncFallbackData& sync_fallback_data1,
                 const WebApp::SyncFallbackData& sync_fallback_data2);
 
-bool operator==(const WebApp& app1, const WebApp& app2);
-bool operator!=(const WebApp& app1, const WebApp& app2);
-
 }  // namespace web_app
 
 #endif  // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_