Commit fd2760c0 authored by Andreas Haas's avatar Andreas Haas Committed by Commit Bot

[arraybuffer] Remove unused parameter of ArrayBufferContents constructor

The parameter was not used anymore.

R=haraken@chromium.org
CC=​ulan@chromium.org

Bug: chromium:1008840
Change-Id: I4651b4e9bdb4425820316d998ff3b9d11aaab90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893276Reviewed-by: default avatarCorentin Wallez <cwallez@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713420}
parent ce717a5e
...@@ -243,12 +243,10 @@ MojoMapBufferResult* MojoHandle::mapBuffer(unsigned offset, ...@@ -243,12 +243,10 @@ MojoMapBufferResult* MojoHandle::mapBuffer(unsigned offset,
result_dict->setResult(result); result_dict->setResult(result);
if (result == MOJO_RESULT_OK) { if (result == MOJO_RESULT_OK) {
ArrayBufferContents contents( ArrayBufferContents contents(
data, num_bytes, data, num_bytes, [](void* buffer, size_t length, void* alloc_data) {
[](void* buffer, size_t length, void* alloc_data) {
MojoResult result = MojoUnmapBuffer(buffer); MojoResult result = MojoUnmapBuffer(buffer);
DCHECK_EQ(result, MOJO_RESULT_OK); DCHECK_EQ(result, MOJO_RESULT_OK);
}, });
ArrayBufferContents::kNotShared);
result_dict->setBuffer(DOMArrayBuffer::Create(contents)); result_dict->setBuffer(DOMArrayBuffer::Create(contents));
} }
return result_dict; return result_dict;
......
...@@ -36,18 +36,12 @@ namespace blink { ...@@ -36,18 +36,12 @@ namespace blink {
ArrayBufferContents::ArrayBufferContents(void* data, ArrayBufferContents::ArrayBufferContents(void* data,
size_t length, size_t length,
DataDeleter deleter, DataDeleter deleter) {
SharingType is_shared) {
if (!data) { if (!data) {
return; return;
} }
if (is_shared == kNotShared) { backing_store_ =
backing_store_ = v8::ArrayBuffer::NewBackingStore(data, length, deleter, nullptr);
v8::ArrayBuffer::NewBackingStore(data, length, deleter, nullptr);
} else {
backing_store_ =
v8::SharedArrayBuffer::NewBackingStore(data, length, deleter, nullptr);
}
} }
ArrayBufferContents::ArrayBufferContents( ArrayBufferContents::ArrayBufferContents(
......
...@@ -63,10 +63,7 @@ class CORE_EXPORT ArrayBufferContents { ...@@ -63,10 +63,7 @@ class CORE_EXPORT ArrayBufferContents {
size_t element_byte_size, size_t element_byte_size,
SharingType is_shared, SharingType is_shared,
InitializationPolicy); InitializationPolicy);
ArrayBufferContents(void* data, ArrayBufferContents(void* data, size_t length, DataDeleter deleter);
size_t length,
DataDeleter deleter,
SharingType is_shared);
ArrayBufferContents(ArrayBufferContents&&) = default; ArrayBufferContents(ArrayBufferContents&&) = default;
explicit ArrayBufferContents(std::shared_ptr<v8::BackingStore> backing_store); explicit ArrayBufferContents(std::shared_ptr<v8::BackingStore> backing_store);
......
...@@ -61,12 +61,11 @@ WGPUBufferDescriptor AsDawnType(const GPUBufferDescriptor* webgpu_desc) { ...@@ -61,12 +61,11 @@ WGPUBufferDescriptor AsDawnType(const GPUBufferDescriptor* webgpu_desc) {
DOMArrayBuffer* CreateArrayBufferForMappedData(void* data, size_t data_length) { DOMArrayBuffer* CreateArrayBufferForMappedData(void* data, size_t data_length) {
DCHECK(data); DCHECK(data);
ArrayBufferContents contents( ArrayBufferContents contents(data, data_length,
data, data_length, [](void* data, size_t length, void* info) {
[](void* data, size_t length, void* info) { // DataDeleter does nothing because Dawn wire
// DataDeleter does nothing because Dawn wire owns the memory. // owns the memory.
}, });
ArrayBufferContents::SharingType::kNotShared);
return DOMArrayBuffer::Create(contents); return DOMArrayBuffer::Create(contents);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment