Commit fd60d8ca authored by wychen's avatar wychen Committed by Commit bot

Add missing header files to GN files (4 of N)

I ran check_gn_headers.py on linux and android full builds, merged the
missing header file lists, fed to fix_gn_headers.py (without
AddHeadersToSources), chose which matches to apply interactively, and
manually fixed the results.

Read more about the manual fixes in the Review-Url.

The number of missing header files on linux and android decreased by 9,
from 840 to 831.

None of the fixed files are included in the following spreadsheet:
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0

fix_gn_headers.py is from https://codereview.chromium.org/2790563003

BUG=661774

Review-Url: https://codereview.chromium.org/2846463002
Cr-Commit-Position: refs/heads/master@{#468192}
parent 65790e80
...@@ -867,6 +867,7 @@ test("content_browsertests") { ...@@ -867,6 +867,7 @@ test("content_browsertests") {
sources += [ sources += [
"../browser/accessibility/android_granularity_movement_browsertest.cc", "../browser/accessibility/android_granularity_movement_browsertest.cc",
"../browser/android/render_widget_host_connector_browsertest.cc", "../browser/android/render_widget_host_connector_browsertest.cc",
"../browser/android/render_widget_host_connector_browsertest.h",
"../browser/media/session/audio_focus_delegate_android_browsertest.cc", "../browser/media/session/audio_focus_delegate_android_browsertest.cc",
"../shell/android/browsertests_apk/content_browser_tests_jni_onload.cc", "../shell/android/browsertests_apk/content_browser_tests_jni_onload.cc",
] ]
......
...@@ -1286,6 +1286,7 @@ component("platform") { ...@@ -1286,6 +1286,7 @@ component("platform") {
"scheduler/base/work_queue_sets.cc", "scheduler/base/work_queue_sets.cc",
"scheduler/base/work_queue_sets.h", "scheduler/base/work_queue_sets.h",
"scheduler/child/compositor_worker_scheduler.cc", "scheduler/child/compositor_worker_scheduler.cc",
"scheduler/child/compositor_worker_scheduler.h",
"scheduler/child/idle_canceled_delayed_task_sweeper.cc", "scheduler/child/idle_canceled_delayed_task_sweeper.cc",
"scheduler/child/idle_canceled_delayed_task_sweeper.h", "scheduler/child/idle_canceled_delayed_task_sweeper.h",
"scheduler/child/idle_helper.cc", "scheduler/child/idle_helper.cc",
...@@ -1302,9 +1303,11 @@ component("platform") { ...@@ -1302,9 +1303,11 @@ component("platform") {
"scheduler/child/web_task_runner_impl.h", "scheduler/child/web_task_runner_impl.h",
"scheduler/child/webthread_base.cc", "scheduler/child/webthread_base.cc",
"scheduler/child/webthread_impl_for_worker_scheduler.cc", "scheduler/child/webthread_impl_for_worker_scheduler.cc",
"scheduler/child/webthread_impl_for_worker_scheduler.h",
"scheduler/child/worker_global_scope_scheduler.cc", "scheduler/child/worker_global_scope_scheduler.cc",
"scheduler/child/worker_global_scope_scheduler.h", "scheduler/child/worker_global_scope_scheduler.h",
"scheduler/child/worker_scheduler.cc", "scheduler/child/worker_scheduler.cc",
"scheduler/child/worker_scheduler.h",
"scheduler/child/worker_scheduler_impl.cc", "scheduler/child/worker_scheduler_impl.cc",
"scheduler/child/worker_scheduler_impl.h", "scheduler/child/worker_scheduler_impl.h",
"scheduler/renderer/auto_advancing_virtual_time_domain.cc", "scheduler/renderer/auto_advancing_virtual_time_domain.cc",
...@@ -1338,6 +1341,7 @@ component("platform") { ...@@ -1338,6 +1341,7 @@ component("platform") {
"scheduler/renderer/webthread_impl_for_renderer_scheduler.cc", "scheduler/renderer/webthread_impl_for_renderer_scheduler.cc",
"scheduler/renderer/webthread_impl_for_renderer_scheduler.h", "scheduler/renderer/webthread_impl_for_renderer_scheduler.h",
"scheduler/utility/webthread_impl_for_utility_thread.cc", "scheduler/utility/webthread_impl_for_utility_thread.cc",
"scheduler/utility/webthread_impl_for_utility_thread.h",
"scroll/MainThreadScrollingReason.h", "scroll/MainThreadScrollingReason.h",
"scroll/ProgrammaticScrollAnimator.cpp", "scroll/ProgrammaticScrollAnimator.cpp",
"scroll/ProgrammaticScrollAnimator.h", "scroll/ProgrammaticScrollAnimator.h",
...@@ -1486,11 +1490,6 @@ component("platform") { ...@@ -1486,11 +1490,6 @@ component("platform") {
"weborigin/URLSecurityOriginMap.h", "weborigin/URLSecurityOriginMap.h",
] ]
if (is_android) {
set_sources_assignment_filter([])
sources += [ "exported/linux/WebFontRenderStyle.cpp" ]
}
sources -= blink_platform_neon_files sources -= blink_platform_neon_files
sources -= blink_platform_msa_files sources -= blink_platform_msa_files
sources -= blink_platform_sse_files sources -= blink_platform_sse_files
...@@ -1613,6 +1612,7 @@ component("platform") { ...@@ -1613,6 +1612,7 @@ component("platform") {
# Add in some Linux files also shared with Android. # Add in some Linux files also shared with Android.
set_sources_assignment_filter([]) set_sources_assignment_filter([])
sources += [ sources += [
"exported/linux/WebFontRenderStyle.cpp",
"fonts/linux/FontPlatformDataLinux.cpp", "fonts/linux/FontPlatformDataLinux.cpp",
"fonts/linux/FontRenderStyle.cpp", "fonts/linux/FontRenderStyle.cpp",
"fonts/linux/FontRenderStyle.h", "fonts/linux/FontRenderStyle.h",
......
...@@ -430,6 +430,7 @@ source_set("blink_headers") { ...@@ -430,6 +430,7 @@ source_set("blink_headers") {
"platform/modules/serviceworker/WebServiceWorkerResponseType.h", "platform/modules/serviceworker/WebServiceWorkerResponseType.h",
"platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h", "platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h",
"platform/modules/serviceworker/WebServiceWorkerState.h", "platform/modules/serviceworker/WebServiceWorkerState.h",
"platform/modules/serviceworker/WebServiceWorkerStreamHandle.h",
"platform/modules/vr/WebVR.h", "platform/modules/vr/WebVR.h",
"platform/modules/webmidi/WebMIDIAccessor.h", "platform/modules/webmidi/WebMIDIAccessor.h",
"platform/modules/webmidi/WebMIDIAccessorClient.h", "platform/modules/webmidi/WebMIDIAccessorClient.h",
...@@ -621,6 +622,16 @@ source_set("blink_headers") { ...@@ -621,6 +622,16 @@ source_set("blink_headers") {
"web/win/WebFontRendering.h", "web/win/WebFontRendering.h",
] ]
if (is_android) {
# Android uses some Linux sources, put those back.
set_sources_assignment_filter([])
sources += [
"platform/linux/WebFontRenderStyle.h",
"web/linux/WebFontRendering.h",
]
set_sources_assignment_filter(sources_assignment_filter)
}
public_configs = [ public_configs = [
":blink_headers_config", ":blink_headers_config",
......
...@@ -289,7 +289,10 @@ component("gfx") { ...@@ -289,7 +289,10 @@ component("gfx") {
"text_utils_android.cc", "text_utils_android.cc",
] ]
set_sources_assignment_filter([]) set_sources_assignment_filter([])
sources += [ "platform_font_linux.cc" ] sources += [
"platform_font_linux.cc",
"platform_font_linux.h",
]
set_sources_assignment_filter(sources_assignment_filter) set_sources_assignment_filter(sources_assignment_filter)
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment