Commit fd62c4af authored by Dominic Battre's avatar Dominic Battre Committed by Commit Bot

More debug output for crbug.com/967588

The added debug output indicates that the interactive UI tests of autofill fail
during the setup of the fixture, before the test logic starts (see
crbug.com/967588). This CL adds more debug data to pin point the location where
things fall apart.

Bug: 967588
Change-Id: Ib7b9df7ba7a9ad09f65c11e50feeaa6c81aab0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635682
Auto-Submit: Dominic Battré <battre@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: default avatarFabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665120}
parent 4accd2cb
......@@ -269,11 +269,16 @@ class AutofillInteractiveTestBase : public AutofillUiTest {
// InProcessBrowserTest:
void SetUp() override {
LOG(ERROR) << "crbug/967588: AutofillInteractiveTestBase::SetUp() entered";
ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
LOG(ERROR) << "crbug/967588: embedded_test_server InitializeAndListen";
InProcessBrowserTest::SetUp();
LOG(ERROR) << "crbug/967588: AutofillInteractiveTestBase::SetUp() exited";
}
void SetUpOnMainThread() override {
LOG(ERROR) << "crbug/967588: "
"AutofillInteractiveTestBase::SetUpOnMainThread() entered";
AutofillUiTest::SetUpOnMainThread();
https_server_.SetSSLConfig(net::EmbeddedTestServer::CERT_OK);
......@@ -282,6 +287,7 @@ class AutofillInteractiveTestBase : public AutofillUiTest {
&AutofillInteractiveTestBase::HandleTestURL, base::Unretained(this)));
ASSERT_TRUE(https_server_.InitializeAndListen());
https_server_.StartAcceptingConnections();
LOG(ERROR) << "crbug/967588: https_server started accepting connections";
controllable_http_response_ =
std::make_unique<net::test_server::ControllableHttpResponse>(
......@@ -293,10 +299,14 @@ class AutofillInteractiveTestBase : public AutofillUiTest {
embedded_test_server()->RegisterRequestHandler(base::BindRepeating(
&AutofillInteractiveTestBase::HandleTestURL, base::Unretained(this)));
embedded_test_server()->StartAcceptingConnections();
LOG(ERROR)
<< "crbug/967588: embedded_test_server started accepting connections";
// By default, all SSL cert checks are valid. Can be overriden in tests if
// needed.
cert_verifier_.mock_cert_verifier()->set_default_result(net::OK);
LOG(ERROR) << "crbug/967588: "
"AutofillInteractiveTestBase::SetUpOnMainThread() exited";
}
void SetUpCommandLine(base::CommandLine* command_line) override {
......
......@@ -71,6 +71,7 @@ AutofillUiTest::AutofillUiTest()
AutofillUiTest::~AutofillUiTest() {}
void AutofillUiTest::SetUpOnMainThread() {
LOG(ERROR) << "crbug/967588: AutofillUiTest::SetUpOnMainThread() entered";
// Don't want Keychain coming up on Mac.
test::DisableSystemServices(browser()->profile()->GetPrefs());
......@@ -85,6 +86,7 @@ void AutofillUiTest::SetUpOnMainThread() {
gfx::Point reset_mouse(GetWebContents()->GetContainerBounds().origin());
reset_mouse = gfx::Point(reset_mouse.x() + 5, reset_mouse.y() + 5);
ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(reset_mouse));
LOG(ERROR) << "crbug/967588: AutofillUiTest::SetUpOnMainThread() exited";
}
void AutofillUiTest::TearDownOnMainThread() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment