[iOS] Updating GetSyncErrorDescriptionForBrowserState() API

Replacing GetSyncErrorDescriptionForBrowserState() by
GetSyncErrorDescriptionForSyncSetupService().

Browser state is not always available. This patch is to prepare for
crrev.com/c/1231333

Bug: 849754
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iec560ea22b8e8344cca29de036aef299e8e7b667
Reviewed-on: https://chromium-review.googlesource.com/1234155Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593021}

ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

@@ -321,7 +321,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
     // Sync error.
     syncItem.shouldDisplayError = YES;
     NSString* errorMessage =
-        GetSyncErrorDescriptionForBrowserState(_browserState);
+        GetSyncErrorDescriptionForSyncSetupService(syncSetupService);
     DCHECK(errorMessage);
     syncItem.image = [UIImage imageNamed:@"settings_error"];
     syncItem.detailText = errorMessage;

ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

@@ -1100,7 +1100,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
       !IsTransientSyncError(syncSetupService->GetSyncServiceState());
   if (identityAccountItem.shouldDisplayError) {
     identityAccountItem.detailText =
-        GetSyncErrorDescriptionForBrowserState(_browserState);
+        GetSyncErrorDescriptionForSyncSetupService(syncSetupService);
   } else {
     identityAccountItem.detailText =
         syncSetupService->IsSyncEnabled()

ios/chrome/browser/ui/settings/sync_utils/sync_util.h

@@ -18,9 +18,9 @@ class ChromeBrowserState;
 }
 
 // Gets the top-level description message associated with the sync error state
-// of |browserState|. Returns nil if there is no sync error.
-NSString* GetSyncErrorDescriptionForBrowserState(
-    ios::ChromeBrowserState* browserState);
+// of |syncSetupService|. Returns nil if there is no sync error.
+NSString* GetSyncErrorDescriptionForSyncSetupService(
+    SyncSetupService* syncSetupService);
 
 // Gets the string message associated with the sync error state of
 // |browserState|. The returned error message does not contain any links.

ios/chrome/browser/ui/settings/sync_utils/sync_util.mm

@@ -37,10 +37,8 @@ enum ErrorState {
 
 }  // namespace
 
-NSString* GetSyncErrorDescriptionForBrowserState(
-    ios::ChromeBrowserState* browserState) {
-  SyncSetupService* syncSetupService =
-      SyncSetupServiceFactory::GetForBrowserState(browserState);
+NSString* GetSyncErrorDescriptionForSyncSetupService(
+    SyncSetupService* syncSetupService) {
   DCHECK(syncSetupService);
   SyncSetupService::SyncServiceState syncState =
       syncSetupService->GetSyncServiceState();