Commit fd833d88 authored by Jasper Chapman-Black's avatar Jasper Chapman-Black Committed by Commit Bot

SuperSize: Caspian: Method count mode

This is the last minor feature needed to bring Caspian to parity with
the JS-backed Tiger Viewer. One more major feature to go, diff mode.

Bug: 1011921
Change-Id: Iefbc340f372fa8debad77460a5d3cefda5f54129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894178
Auto-Submit: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712253}
parent fbbf432b
......@@ -229,7 +229,9 @@ function parseOptions(options) {
const excludeRegex = params.get('exclude');
let includeSections = params.get('type');
if (includeSections === null) {
if (methodCountMode) {
includeSections = _DEX_METHOD_SYMBOL_TYPE;
} else if (includeSections === null) {
// Exclude native symbols by default.
let includeSectionsSet = new Set(_SYMBOL_TYPE_SET);
includeSectionsSet.delete('b');
......@@ -244,7 +246,6 @@ function parseOptions(options) {
minSymbolSize,
flagToFilter,
url,
methodCountMode
};
}
......@@ -259,7 +260,6 @@ const actions = {
minSymbolSize,
flagToFilter,
url,
methodCountMode
} = parseOptions(options);
if (input === 'from-url://' && url) {
// Display the data from the `load_url` query parameter
......@@ -272,7 +272,7 @@ const actions = {
return buildTree(
groupBy, includeRegex, excludeRegex, includeSections, minSymbolSize,
flagToFilter, methodCountMode, progress => {
flagToFilter, progress => {
// @ts-ignore
self.postMessage(progress);
});
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment