Commit fd84d016 authored by Albert J. Wong's avatar Albert J. Wong Committed by Commit Bot

Delete RenderView after RenderWidget destructor.

This changes the deletion order of RenderView and RenderWidget.
From analysis, it seems the two pieces of code should be independent.

Bug: 545684
Change-Id: I470c390eb7c3e51a6868fa758f76718c3d1cdcf7
Reviewed-on: https://chromium-review.googlesource.com/c/1387747Reviewed-by: default avatarAlbert J. Wong <ajwong@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618390}
parent c98bc5c2
...@@ -442,12 +442,6 @@ RenderWidget::RenderWidget(int32_t widget_routing_id, ...@@ -442,12 +442,6 @@ RenderWidget::RenderWidget(int32_t widget_routing_id,
RenderWidget::~RenderWidget() { RenderWidget::~RenderWidget() {
DCHECK(!webwidget_internal_) << "Leaking our WebWidget!"; DCHECK(!webwidget_internal_) << "Leaking our WebWidget!";
// TODO(ajwong): Test if this actually has to be reset here
// or if it is okay to tear down later in the destructor. This
// would allow for removing the ordering constraint in teardown.
// https://crbug.com/545684
delegate_.reset();
// TODO(ajwong): Add in check that routing_id_ has been removed from // TODO(ajwong): Add in check that routing_id_ has been removed from
// g_routing_id_widget_map once the shutdown semantics for RenderWidget // g_routing_id_widget_map once the shutdown semantics for RenderWidget
// and RenderViewImpl are rationalized. Currently, too many unit and // and RenderViewImpl are rationalized. Currently, too many unit and
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment