Commit fd8b39f3 authored by tfarina@chromium.org's avatar tfarina@chromium.org

bookmarks: Rename ExtensionBookmarkManagerEventRouter.

Note: This was a TODO for aa@.

R=sky@chromium.org

Review URL: http://codereview.chromium.org/8416036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107945 0039d316-1c4b-4281-b951-d872f2087c98
parent e38219d3
...@@ -146,19 +146,19 @@ void BookmarkNodeDataToJSON(Profile* profile, const BookmarkNodeData& data, ...@@ -146,19 +146,19 @@ void BookmarkNodeDataToJSON(Profile* profile, const BookmarkNodeData& data,
} // namespace } // namespace
ExtensionBookmarkManagerEventRouter::ExtensionBookmarkManagerEventRouter( BookmarkManagerExtensionEventRouter::BookmarkManagerExtensionEventRouter(
Profile* profile, TabContentsWrapper* tab) Profile* profile, TabContentsWrapper* tab)
: profile_(profile), : profile_(profile),
tab_(tab) { tab_(tab) {
tab_->bookmark_tab_helper()->SetBookmarkDragDelegate(this); tab_->bookmark_tab_helper()->SetBookmarkDragDelegate(this);
} }
ExtensionBookmarkManagerEventRouter::~ExtensionBookmarkManagerEventRouter() { BookmarkManagerExtensionEventRouter::~BookmarkManagerExtensionEventRouter() {
if (tab_->bookmark_tab_helper()->GetBookmarkDragDelegate() == this) if (tab_->bookmark_tab_helper()->GetBookmarkDragDelegate() == this)
tab_->bookmark_tab_helper()->SetBookmarkDragDelegate(NULL); tab_->bookmark_tab_helper()->SetBookmarkDragDelegate(NULL);
} }
void ExtensionBookmarkManagerEventRouter::DispatchEvent(const char* event_name, void BookmarkManagerExtensionEventRouter::DispatchEvent(const char* event_name,
const ListValue* args) { const ListValue* args) {
if (!profile_->GetExtensionEventRouter()) if (!profile_->GetExtensionEventRouter())
return; return;
...@@ -169,7 +169,7 @@ void ExtensionBookmarkManagerEventRouter::DispatchEvent(const char* event_name, ...@@ -169,7 +169,7 @@ void ExtensionBookmarkManagerEventRouter::DispatchEvent(const char* event_name,
event_name, json_args, NULL, GURL()); event_name, json_args, NULL, GURL());
} }
void ExtensionBookmarkManagerEventRouter::DispatchDragEvent( void BookmarkManagerExtensionEventRouter::DispatchDragEvent(
const BookmarkNodeData& data, const char* event_name) { const BookmarkNodeData& data, const char* event_name) {
if (data.size() == 0) if (data.size() == 0)
return; return;
...@@ -179,23 +179,23 @@ void ExtensionBookmarkManagerEventRouter::DispatchDragEvent( ...@@ -179,23 +179,23 @@ void ExtensionBookmarkManagerEventRouter::DispatchDragEvent(
DispatchEvent(event_name, &args); DispatchEvent(event_name, &args);
} }
void ExtensionBookmarkManagerEventRouter::OnDragEnter( void BookmarkManagerExtensionEventRouter::OnDragEnter(
const BookmarkNodeData& data) { const BookmarkNodeData& data) {
DispatchDragEvent(data, keys::kOnBookmarkDragEnter); DispatchDragEvent(data, keys::kOnBookmarkDragEnter);
} }
void ExtensionBookmarkManagerEventRouter::OnDragOver( void BookmarkManagerExtensionEventRouter::OnDragOver(
const BookmarkNodeData& data) { const BookmarkNodeData& data) {
// Intentionally empty since these events happens too often and floods the // Intentionally empty since these events happens too often and floods the
// message queue. We do not need this event for the bookmark manager anyway. // message queue. We do not need this event for the bookmark manager anyway.
} }
void ExtensionBookmarkManagerEventRouter::OnDragLeave( void BookmarkManagerExtensionEventRouter::OnDragLeave(
const BookmarkNodeData& data) { const BookmarkNodeData& data) {
DispatchDragEvent(data, keys::kOnBookmarkDragLeave); DispatchDragEvent(data, keys::kOnBookmarkDragLeave);
} }
void ExtensionBookmarkManagerEventRouter::OnDrop( void BookmarkManagerExtensionEventRouter::OnDrop(
const BookmarkNodeData& data) { const BookmarkNodeData& data) {
DispatchDragEvent(data, keys::kOnBookmarkDrop); DispatchDragEvent(data, keys::kOnBookmarkDrop);
...@@ -205,13 +205,13 @@ void ExtensionBookmarkManagerEventRouter::OnDrop( ...@@ -205,13 +205,13 @@ void ExtensionBookmarkManagerEventRouter::OnDrop(
} }
const BookmarkNodeData* const BookmarkNodeData*
ExtensionBookmarkManagerEventRouter::GetBookmarkNodeData() { BookmarkManagerExtensionEventRouter::GetBookmarkNodeData() {
if (bookmark_drag_data_.is_valid()) if (bookmark_drag_data_.is_valid())
return &bookmark_drag_data_; return &bookmark_drag_data_;
return NULL; return NULL;
} }
void ExtensionBookmarkManagerEventRouter::ClearBookmarkNodeData() { void BookmarkManagerExtensionEventRouter::ClearBookmarkNodeData() {
bookmark_drag_data_.Clear(); bookmark_drag_data_.Clear();
} }
...@@ -420,8 +420,8 @@ bool DropBookmarkManagerFunction::RunImpl() { ...@@ -420,8 +420,8 @@ bool DropBookmarkManagerFunction::RunImpl() {
ExtensionWebUI* web_ui = ExtensionWebUI* web_ui =
static_cast<ExtensionWebUI*>(tab_contents->web_ui()); static_cast<ExtensionWebUI*>(tab_contents->web_ui());
CHECK(web_ui); CHECK(web_ui);
ExtensionBookmarkManagerEventRouter* router = BookmarkManagerExtensionEventRouter* router =
web_ui->extension_bookmark_manager_event_router(); web_ui->bookmark_manager_extension_event_router();
DCHECK(router); DCHECK(router);
const BookmarkNodeData* drag_data = router->GetBookmarkNodeData(); const BookmarkNodeData* drag_data = router->GetBookmarkNodeData();
......
...@@ -20,13 +20,12 @@ class ListValue; ...@@ -20,13 +20,12 @@ class ListValue;
} }
// Class that handles the chrome.experimental.bookmarkManager events. // Class that handles the chrome.experimental.bookmarkManager events.
// TODO(aa): Rename this class BookmarkManagerExtensionEventRouter
class ExtensionBookmarkManagerEventRouter
: public BookmarkTabHelper::BookmarkDrag { : public BookmarkTabHelper::BookmarkDrag {
public: public:
ExtensionBookmarkManagerEventRouter(Profile* profile, BookmarkManagerExtensionEventRouter(Profile* profile,
TabContentsWrapper* tab); TabContentsWrapper* tab);
virtual ~ExtensionBookmarkManagerEventRouter(); virtual ~BookmarkManagerExtensionEventRouter();
// RenderViewHostDelegate::BookmarkDrag interface // RenderViewHostDelegate::BookmarkDrag interface
virtual void OnDragEnter(const BookmarkNodeData& data); virtual void OnDragEnter(const BookmarkNodeData& data);
...@@ -51,7 +50,7 @@ class ExtensionBookmarkManagerEventRouter ...@@ -51,7 +50,7 @@ class ExtensionBookmarkManagerEventRouter
TabContentsWrapper* tab_; TabContentsWrapper* tab_;
BookmarkNodeData bookmark_drag_data_; BookmarkNodeData bookmark_drag_data_;
DISALLOW_COPY_AND_ASSIGN(ExtensionBookmarkManagerEventRouter); DISALLOW_COPY_AND_ASSIGN(BookmarkManagerExtensionEventRouter);
}; };
class ClipboardBookmarkManagerFunction : public BookmarksFunction { class ClipboardBookmarkManagerFunction : public BookmarksFunction {
......
...@@ -162,8 +162,8 @@ ExtensionWebUI::ExtensionWebUI(TabContents* tab_contents, const GURL& url) ...@@ -162,8 +162,8 @@ ExtensionWebUI::ExtensionWebUI(TabContents* tab_contents, const GURL& url)
TabContentsWrapper* tab = TabContentsWrapper* tab =
TabContentsWrapper::GetCurrentWrapperForContents(tab_contents_); TabContentsWrapper::GetCurrentWrapperForContents(tab_contents_);
DCHECK(tab); DCHECK(tab);
extension_bookmark_manager_event_router_.reset( bookmark_manager_extension_event_router_.reset(
new ExtensionBookmarkManagerEventRouter(profile, tab)); new BookmarkManagerExtensionEventRouter(profile, tab));
link_transition_type_ = content::PAGE_TRANSITION_AUTO_BOOKMARK; link_transition_type_ = content::PAGE_TRANSITION_AUTO_BOOKMARK;
} }
...@@ -171,9 +171,9 @@ ExtensionWebUI::ExtensionWebUI(TabContents* tab_contents, const GURL& url) ...@@ -171,9 +171,9 @@ ExtensionWebUI::ExtensionWebUI(TabContents* tab_contents, const GURL& url)
ExtensionWebUI::~ExtensionWebUI() {} ExtensionWebUI::~ExtensionWebUI() {}
ExtensionBookmarkManagerEventRouter* BookmarkManagerExtensionEventRouter*
ExtensionWebUI::extension_bookmark_manager_event_router() { ExtensionWebUI::bookmark_manager_extension_event_router() {
return extension_bookmark_manager_event_router_.get(); return bookmark_manager_extension_event_router_.get();
} }
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
......
...@@ -37,8 +37,8 @@ class ExtensionWebUI : public ChromeWebUI { ...@@ -37,8 +37,8 @@ class ExtensionWebUI : public ChromeWebUI {
virtual ~ExtensionWebUI(); virtual ~ExtensionWebUI();
virtual ExtensionBookmarkManagerEventRouter* virtual BookmarkManagerExtensionEventRouter*
extension_bookmark_manager_event_router(); bookmark_manager_extension_event_router();
// BrowserURLHandler // BrowserURLHandler
static bool HandleChromeURLOverride(GURL* url, static bool HandleChromeURLOverride(GURL* url,
...@@ -75,8 +75,8 @@ class ExtensionWebUI : public ChromeWebUI { ...@@ -75,8 +75,8 @@ class ExtensionWebUI : public ChromeWebUI {
// TODO(aa): This seems out of place. Why is it not with the event routers for // TODO(aa): This seems out of place. Why is it not with the event routers for
// the other extension APIs? // the other extension APIs?
scoped_ptr<ExtensionBookmarkManagerEventRouter> scoped_ptr<BookmarkManagerExtensionEventRouter>
extension_bookmark_manager_event_router_; bookmark_manager_extension_event_router_;
// The URL this WebUI was created for. // The URL this WebUI was created for.
GURL url_; GURL url_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment