Commit fda99bfd authored by Fred Mello's avatar Fred Mello Committed by Commit Bot

Fix interface declaration for logging status

Also renamed param from status to errorCode.

Bug: 1005802
Change-Id: Iee6991724fb10b9e30ca7919ae21e5a4829e3324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838415
Commit-Queue: Fred Mello <fredmello@chromium.org>
Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702702}
parent ad5c2634
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
package org.chromium.components.module_installer.logger; package org.chromium.components.module_installer.logger;
import com.google.android.play.core.splitinstall.model.SplitInstallErrorCode; import com.google.android.play.core.splitinstall.model.SplitInstallErrorCode;
import com.google.android.play.core.splitinstall.model.SplitInstallSessionStatus;
/** /**
* Logger for SplitCompat Engine. * Logger for SplitCompat Engine.
...@@ -14,17 +15,17 @@ public interface Logger { ...@@ -14,17 +15,17 @@ public interface Logger {
* Logs exceptions that happen during module request. * Logs exceptions that happen during module request.
* *
* @param moduleName The module name. * @param moduleName The module name.
* @param status The error code. * @param errorCode The error code.
*/ */
void logRequestFailure(String moduleName, @SplitInstallErrorCode int status); void logRequestFailure(String moduleName, @SplitInstallErrorCode int errorCode);
/** /**
* Logs exceptions that happen during the installation process. * Logs exceptions that happen during the installation process.
* *
* @param moduleName The module name. * @param moduleName The module name.
* @param status The error code. * @param errorCode The error code.
*/ */
void logStatusFailure(String moduleName, @SplitInstallErrorCode int status); void logStatusFailure(String moduleName, @SplitInstallErrorCode int errorCode);
/** /**
* Logs the status count and duration during a module installation process. * Logs the status count and duration during a module installation process.
...@@ -32,7 +33,7 @@ public interface Logger { ...@@ -32,7 +33,7 @@ public interface Logger {
* @param moduleName The module name * @param moduleName The module name
* @param status The status code * @param status The status code
*/ */
void logStatus(String moduleName, @SplitInstallErrorCode int status); void logStatus(String moduleName, @SplitInstallSessionStatus int status);
/** /**
* Logs the request start time. * Logs the request start time.
......
...@@ -28,13 +28,13 @@ public class PlayCoreLogger implements Logger { ...@@ -28,13 +28,13 @@ public class PlayCoreLogger implements Logger {
} }
@Override @Override
public void logRequestFailure(String moduleName, @SplitInstallErrorCode int status) { public void logRequestFailure(String moduleName, @SplitInstallErrorCode int errorCode) {
mFailureLogger.logRequestFailure(moduleName, status); mFailureLogger.logRequestFailure(moduleName, errorCode);
} }
@Override @Override
public void logStatusFailure(String moduleName, @SplitInstallErrorCode int status) { public void logStatusFailure(String moduleName, @SplitInstallErrorCode int errorCode) {
mFailureLogger.logStatusFailure(moduleName, status); mFailureLogger.logStatusFailure(moduleName, errorCode);
} }
@Override @Override
......
...@@ -87,13 +87,13 @@ class SplitInstallFailureLogger { ...@@ -87,13 +87,13 @@ class SplitInstallFailureLogger {
log(moduleName, NO_SPLITCOMPAT); log(moduleName, NO_SPLITCOMPAT);
} }
public void logStatusFailure(String moduleName, @SplitInstallErrorCode int status) { public void logStatusFailure(String moduleName, @SplitInstallErrorCode int errorCode) {
Integer code = getHistogramCode(status); Integer code = getHistogramCode(errorCode);
log(moduleName, code == -1 ? UNKNOWN_SPLITINSTALL_ERROR : code); log(moduleName, code == -1 ? UNKNOWN_SPLITINSTALL_ERROR : code);
} }
public void logRequestFailure(String moduleName, @SplitInstallErrorCode int status) { public void logRequestFailure(String moduleName, @SplitInstallErrorCode int errorCode) {
Integer code = getHistogramCode(status); Integer code = getHistogramCode(errorCode);
log(moduleName, code == -1 ? UNKNOWN_REQUEST_ERROR : code); log(moduleName, code == -1 ? UNKNOWN_REQUEST_ERROR : code);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment