Commit fdb176eb authored by mlerman's avatar mlerman Committed by Commit bot

On Views, track all opens of the menu from icon AND bubble. Matches Mac.

Currently, this metric on cocoa tracks opening the user menu from the
icon or bubble, but on Views only from the icon. We want to also track
opening the new User Menu in Views with this stat.

BUG=NONE

Review URL: https://codereview.chromium.org/702483002

Cr-Commit-Position: refs/heads/master@{#302469}
parent b20bc1fc
...@@ -49,8 +49,8 @@ class ProfileMetrics { ...@@ -49,8 +49,8 @@ class ProfileMetrics {
// Enum for counting the ways user profiles and menus were opened. // Enum for counting the ways user profiles and menus were opened.
enum ProfileOpen { enum ProfileOpen {
NTP_AVATAR_BUBBLE = 0, // User opens avatar icon menu from NTP NTP_AVATAR_BUBBLE = 0, // User opens avatar menu from NTP
ICON_AVATAR_BUBBLE, // User opens avatar icon menu from icon ICON_AVATAR_BUBBLE, // User opens the avatar menu from button
SWITCH_PROFILE_ICON, // User switches profiles from icon menu SWITCH_PROFILE_ICON, // User switches profiles from icon menu
SWITCH_PROFILE_MENU, // User switches profiles from menu bar SWITCH_PROFILE_MENU, // User switches profiles from menu bar
SWITCH_PROFILE_DOCK, // User switches profiles from dock (Mac-only) SWITCH_PROFILE_DOCK, // User switches profiles from dock (Mac-only)
......
...@@ -2431,8 +2431,8 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton( ...@@ -2431,8 +2431,8 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(
views::BubbleBorder::PAINT_NORMAL; views::BubbleBorder::PAINT_NORMAL;
AvatarMenuBubbleView::ShowBubble(anchor_view, arrow, arrow_paint_type, AvatarMenuBubbleView::ShowBubble(anchor_view, arrow, arrow_paint_type,
alignment, bounds, browser()); alignment, bounds, browser());
ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);
} }
ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);
} }
int BrowserView::GetRenderViewHeightInsetWithDetachedBookmarkBar() { int BrowserView::GetRenderViewHeightInsetWithDetachedBookmarkBar() {
......
...@@ -51657,8 +51657,8 @@ To add a new entry, add it with any value and run test to compute valid value. ...@@ -51657,8 +51657,8 @@ To add a new entry, add it with any value and run test to compute valid value.
</enum> </enum>
<enum name="ProfileOpenMethod" type="int"> <enum name="ProfileOpenMethod" type="int">
<int value="0" label="Opened the avatar bubble menu from NTP"/> <int value="0" label="Opened the avatar menu from NTP"/>
<int value="1" label="Opened the avatar bubble menu from icon"/> <int value="1" label="Opened the avatar menu from avatar button"/>
<int value="2" label="Switch to profile from icon menu"/> <int value="2" label="Switch to profile from icon menu"/>
<int value="3" label="Switch to profile from title bar menu"/> <int value="3" label="Switch to profile from title bar menu"/>
<int value="4" label="Switch to profile from Mac OS X Dock menu"/> <int value="4" label="Switch to profile from Mac OS X Dock menu"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment