Commit fdb73a33 authored by Darren Shen's avatar Darren Shen Committed by Chromium LUCI CQ

ime: Fix ASAN/MSAN test failure for NativeInputMethodEngine browser tests.

The issue is that NativeInputMethodEngine observes
ChromeKeyboardControllerClient, but in the browser tests,
ChromeKeyboardControllerClient is deleted before NativeInputMethodEngine

Change NativeInputMethodEngine to a pointer so that we can delete it
before ChromeKeyboardControllerClient. We need to delete it in
TearDownOnMainThread because that's when the
ChromeKeyboardControllerClient is deleted.

Bug: 1157432
Change-Id: I9f076ace3079b0fea2d7bda7a0fa780dade2a9c3
Fixed: 1157432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586166
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: default avatarJing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835997}
parent dcd1058f
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment