Commit fdd438d0 authored by Henrique Nakashima's avatar Henrique Nakashima Committed by Commit Bot

Suppress UseSharedPreferencesManagerFromChromeCheck for TestUtil(s).

Files named FooTestUtil.java and FooTestUtils.java don't need to
use SharedPreferencesManager.

Bug: 1034960
Change-Id: I462a6e4c638eebef390b00939ebd782c87e1940e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974397Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726053}
parent ed63cf9b
...@@ -5,8 +5,9 @@ ...@@ -5,8 +5,9 @@
<!-- Code in chrome/ should use SharedPreferencesManager. Ref: crbug.com/1022108 --> <!-- Code in chrome/ should use SharedPreferencesManager. Ref: crbug.com/1022108 -->
<suppress id="UseSharedPreferencesManagerFromChromeCheck" <suppress id="UseSharedPreferencesManagerFromChromeCheck"
files="src/(android_webview|base|chromecast|components|content|device|media|net|remoting|services|testing|third_party|tools|ui|weblayer)/"/> files="src/(android_webview|base|chromecast|components|content|device|media|net|remoting|services|testing|third_party|tools|ui|weblayer)/"/>
<!-- FooTest.java, FooTestUtil.java, and FooTestUtils.java do not need to use SharedPreferencesManager. -->
<suppress id="UseSharedPreferencesManagerFromChromeCheck" <suppress id="UseSharedPreferencesManagerFromChromeCheck"
files="Test.java"/> files="Test(Utils?)?\.java"/>
<!-- All other usages of the app SharedPreference should go through <!-- All other usages of the app SharedPreference should go through
ContextUtils. --> ContextUtils. -->
<suppress id="DefaultSharedPreferencesCheck" files="src/chrome/"/> <suppress id="DefaultSharedPreferencesCheck" files="src/chrome/"/>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment