[opus] Don't print assertion messages in release builds

Bug: 1053572
Change-Id: I60c36728362994815fb376cefe5d623c2bcb3d67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065855Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Felicia Lim <flim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743271}

third_party/opus/BUILD.gn

@@ -65,6 +65,11 @@ config("opus_private_config") {
     ]
   }
 
+  if (is_official_build) {
+    # Disable assertion messages from ENABLE_HARDENING, saving 16.4 kb.
+    defines += [ "CHROMIUM_NO_LOGGING" ]
+  }
+
   if (is_debug) {
     # Turn off a warning in opus_decoder.c when compiling without optimization.
     defines += [ "OPUS_WILL_BE_SLOW" ]

third_party/opus/README.chromium

@@ -14,6 +14,7 @@ encoding/decoding.
 Local changes:
 * copy .gitignore from https://git.xiph.org/?p=opus.git;a=tree
 * set 'x' flags: "chmod 750 win32/genversion.bat"
+* remove assertion messages in release builds (see crbug/1053572)
 
 Opus' own unit tests are located in ./src/tests
 Additional chromium tests are located in ./tests

third_party/opus/src/celt/arch.h

@@ -72,7 +72,9 @@ __attribute__((noreturn))
 #endif
 void celt_fatal(const char *str, const char *file, int line)
 {
+#if !defined(CHROMIUM_NO_LOGGING)
    fprintf (stderr, "Fatal (internal) error in %s, line %d: %s\n", file, line, str);
+#endif
    abort();
 }
 #endif