[Offline Pages] Moving feature flag tests out from model tests.

Separating the feature flag tests from the model tests, in order to make
unit tests for model more slim and reasonable.

Bug: NONE
Change-Id: I5a58e49cb3b76a427eded26818485da18c2e237a
Reviewed-on: https://chromium-review.googlesource.com/727568Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509998}

components/offline_pages/core/BUILD.gn

@@ -136,6 +136,7 @@ source_set("unit_tests") {
     "model/mark_page_accessed_task_unittest.cc",
     "model/temporary_pages_consistency_check_task_unittest.cc",
     "offline_event_logger_unittest.cc",
+    "offline_page_feature_unittest.cc",
     "offline_page_metadata_store_unittest.cc",
     "offline_page_model_event_logger_unittest.cc",
     "offline_page_model_impl_unittest.cc",

components/offline_pages/core/offline_page_feature_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/core/offline_page_feature.h"
+
+#include "base/feature_list.h"
+#include "base/test/scoped_feature_list.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace offline_pages {
+
+TEST(OfflinePageFeatureTest, OfflineBookmarks) {
+  // Enabled by default.
+  EXPECT_TRUE(offline_pages::IsOfflineBookmarksEnabled());
+
+  // Check if feature is correctly disabled by command-line flag.
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndDisableFeature(kOfflineBookmarksFeature);
+  EXPECT_FALSE(offline_pages::IsOfflineBookmarksEnabled());
+}
+
+TEST(OfflinePageFeatureTest, OffliningRecentPages) {
+  // Enabled by default.
+  EXPECT_TRUE(offline_pages::IsOffliningRecentPagesEnabled());
+
+  // Check if feature is correctly disabled by command-line flag.
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndDisableFeature(kOffliningRecentPagesFeature);
+  EXPECT_FALSE(offline_pages::IsOffliningRecentPagesEnabled());
+}
+
+TEST(OfflinePageFeatureTest, OfflinePagesSharing) {
+  // This feature is disabled by default.
+  EXPECT_FALSE(offline_pages::IsOfflinePagesSharingEnabled());
+
+  // Check if feature is correctly disabled by command-line flag.
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(kOfflinePagesSharingFeature);
+  EXPECT_TRUE(offline_pages::IsOfflinePagesSharingEnabled());
+}
+
+TEST(OfflinePageFeatureTest, OfflinePagesSvelteConcurrentLoading) {
+  // This feature is disabled by default.
+  EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
+
+  // Check if feature is correctly enabled by command-line flag.
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(
+      kOfflinePagesSvelteConcurrentLoadingFeature);
+  EXPECT_TRUE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
+}
+
+TEST(OfflinePageFeatureTest, OfflinePagesLoadSignalCollecting) {
+  // This feature is disabled by default.
+  EXPECT_FALSE(offline_pages::IsOfflinePagesLoadSignalCollectingEnabled());
+
+  // Check if feature is correctly enabled by command-line flag.
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(
+      kOfflinePagesLoadSignalCollectingFeature);
+  EXPECT_TRUE(offline_pages::IsOfflinePagesLoadSignalCollectingEnabled());
+}
+
+}  // namespace offline_pages

components/offline_pages/core/offline_page_model_impl_unittest.cc

@@ -1649,56 +1649,4 @@ TEST_F(OfflinePageModelImplTest, MAYBE_CheckPagesSavedInSeparateDirs) {
   EXPECT_NE(temporary_page_path.DirName(), persistent_page_path.DirName());
 }
 
-TEST(CommandLineFlagsTest, OfflineBookmarks) {
-  // Enabled by default.
-  EXPECT_TRUE(offline_pages::IsOfflineBookmarksEnabled());
-
-  // Check if feature is correctly disabled by command-line flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndDisableFeature(kOfflineBookmarksFeature);
-  EXPECT_FALSE(offline_pages::IsOfflineBookmarksEnabled());
-}
-
-TEST(CommandLineFlagsTest, OffliningRecentPages) {
-  // Enabled by default.
-  EXPECT_TRUE(offline_pages::IsOffliningRecentPagesEnabled());
-
-  // Check if feature is correctly disabled by command-line flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndDisableFeature(kOffliningRecentPagesFeature);
-  EXPECT_FALSE(offline_pages::IsOffliningRecentPagesEnabled());
-}
-
-TEST(CommandLineFlagsTest, OfflinePagesSharing) {
-  // This feature is disabled by default.
-  EXPECT_FALSE(offline_pages::IsOfflinePagesSharingEnabled());
-
-  // Check if feature is correctly disabled by command-line flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(kOfflinePagesSharingFeature);
-  EXPECT_TRUE(offline_pages::IsOfflinePagesSharingEnabled());
-}
-
-TEST(CommandLineFlagsTest, OfflinePagesSvelteConcurrentLoading) {
-  // This feature is disabled by default.
-  EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
-
-  // Check if feature is correctly enabled by command-line flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(
-      kOfflinePagesSvelteConcurrentLoadingFeature);
-  EXPECT_TRUE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
-}
-
-TEST(CommandLineFlagsTest, OfflinePagesLoadSignalCollecting) {
-  // This feature is disabled by default.
-  EXPECT_FALSE(offline_pages::IsOfflinePagesLoadSignalCollectingEnabled());
-
-  // Check if feature is correctly enabled by command-line flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(
-      kOfflinePagesLoadSignalCollectingFeature);
-  EXPECT_TRUE(offline_pages::IsOfflinePagesLoadSignalCollectingEnabled());
-}
-
 }  // namespace offline_pages