Commit fe30254f authored by eroman's avatar eroman Committed by Commit bot

Add more instrumentation for tracking jank in ProxyService creation.

BUG=454983

Review URL: https://codereview.chromium.org/982473002

Cr-Commit-Position: refs/heads/master@{#319188}
parent 2555b1b6
...@@ -11,9 +11,10 @@ ...@@ -11,9 +11,10 @@
#include "base/bind_helpers.h" #include "base/bind_helpers.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/memory/scoped_ptr.h" #include "base/memory/scoped_ptr.h"
#include "base/profiler/scoped_tracker.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/string_tokenizer.h" #include "base/strings/string_tokenizer.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_restrictions.h" #include "base/threading/thread_restrictions.h"
#include "base/win/registry.h" #include "base/win/registry.h"
...@@ -62,6 +63,11 @@ void ProxyConfigServiceWin::AddObserver(Observer* observer) { ...@@ -62,6 +63,11 @@ void ProxyConfigServiceWin::AddObserver(Observer* observer) {
} }
void ProxyConfigServiceWin::StartWatchingRegistryForChanges() { void ProxyConfigServiceWin::StartWatchingRegistryForChanges() {
// TODO(eroman): Remove once crbug.com/454983 is solved.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"454983 ProxyConfigServiceWin::StartWatchingRegistryForChanges"));
if (!keys_to_watch_.empty()) if (!keys_to_watch_.empty())
return; // Already initialized. return; // Already initialized.
......
...@@ -904,6 +904,9 @@ ProxyService::ProxyService(ProxyConfigService* config_service, ...@@ -904,6 +904,9 @@ ProxyService::ProxyService(ProxyConfigService* config_service,
stall_proxy_auto_config_delay_(TimeDelta::FromMilliseconds( stall_proxy_auto_config_delay_(TimeDelta::FromMilliseconds(
kDelayAfterNetworkChangesMs)), kDelayAfterNetworkChangesMs)),
quick_check_enabled_(true) { quick_check_enabled_(true) {
// TODO(eroman): Remove once crbug.com/454983 is solved.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION("454983 ProxyService::ProxyService"));
NetworkChangeNotifier::AddIPAddressObserver(this); NetworkChangeNotifier::AddIPAddressObserver(this);
NetworkChangeNotifier::AddDNSObserver(this); NetworkChangeNotifier::AddDNSObserver(this);
ResetConfigService(config_service); ResetConfigService(config_service);
...@@ -1421,6 +1424,11 @@ ProxyService::State ProxyService::ResetProxyConfig(bool reset_fetched_config) { ...@@ -1421,6 +1424,11 @@ ProxyService::State ProxyService::ResetProxyConfig(bool reset_fetched_config) {
void ProxyService::ResetConfigService( void ProxyService::ResetConfigService(
ProxyConfigService* new_proxy_config_service) { ProxyConfigService* new_proxy_config_service) {
// TODO(eroman): Remove once crbug.com/454983 is solved.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"454983 ProxyService::ResetConfigService"));
DCHECK(CalledOnValidThread()); DCHECK(CalledOnValidThread());
State previous_state = ResetProxyConfig(true); State previous_state = ResetProxyConfig(true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment