Commit fe4be3da authored by maniscalco's avatar maniscalco Committed by Commit bot

Revert of Fix errors found in Mac gn component builds (patchset #10 id:180001...

Revert of Fix errors found in Mac gn component builds (patchset #10 id:180001 of https://codereview.chromium.org/1087873003/)

Reason for revert:
Suspected of breaking Mac GN, see https://codereview.chromium.org/1087873003

Original issue's description:
> Fix errors found in Mac gn component builds
>
> Mac gn component build fail because of missing frameworks and missing some other
> dependencies, and occasionally file list out of sync with the gyp counterpart:
> http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio
>
> For instance, the frameworks linked in the components that sync depends on is not
> automatically linked into sync, thus revealing the issue.
>
> Committed: https://crrev.com/ae8297db22a6ca96652d42bd0cdc3deff17aba4a
> Cr-Commit-Position: refs/heads/master@{#325479}

TBR=dpranke@google.com,dpranke@chromium.org,brettw@chromium.org,avi@chromium.org,toyoshim@chromium.org,piman@chromium.org,pavely@chromium.org,dalecurtis@chromium.org,jiangj@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1089773003

Cr-Commit-Position: refs/heads/master@{#325483}
parent b88873e4
...@@ -362,16 +362,8 @@ source_set("browser") { ...@@ -362,16 +362,8 @@ source_set("browser") {
"geolocation/empty_wifi_data_provider.cc", "geolocation/empty_wifi_data_provider.cc",
"geolocation/empty_wifi_data_provider.h", "geolocation/empty_wifi_data_provider.h",
] ]
deps += [ deps += [ "//ui/accelerated_widget_mac" ]
"//sandbox/mac:sandbox", libs += [ "bsm" ]
"//third_party/mozilla",
"//third_party/sudden_motion_sensor",
"//ui/accelerated_widget_mac",
]
libs += [
"bsm",
"QTKit.framework",
]
} }
if (is_chromeos) { if (is_chromeos) {
...@@ -391,8 +383,6 @@ source_set("browser") { ...@@ -391,8 +383,6 @@ source_set("browser") {
] ]
} else { # Not aura. } else { # Not aura.
sources -= [ sources -= [
"renderer_host/compositor_resize_lock_aura.cc",
"renderer_host/compositor_resize_lock_aura.h",
"renderer_host/input/synthetic_gesture_target_aura.cc", "renderer_host/input/synthetic_gesture_target_aura.cc",
"renderer_host/input/synthetic_gesture_target_aura.h", "renderer_host/input/synthetic_gesture_target_aura.h",
"renderer_host/native_web_keyboard_event_aura.cc", "renderer_host/native_web_keyboard_event_aura.cc",
......
...@@ -207,11 +207,6 @@ source_set("common") { ...@@ -207,11 +207,6 @@ source_set("common") {
sources += [ sources += [
"gpu/client/gpu_memory_buffer_impl_io_surface.cc", "gpu/client/gpu_memory_buffer_impl_io_surface.cc",
"gpu/client/gpu_memory_buffer_impl_io_surface.h", "gpu/client/gpu_memory_buffer_impl_io_surface.h",
"gpu/gpu_memory_buffer_factory_io_surface.cc",
"gpu/gpu_memory_buffer_factory_io_surface.h",
"gpu/media/vt.h",
"gpu/media/vt_video_decode_accelerator.cc",
"gpu/media/vt_video_decode_accelerator.h",
] + get_target_outputs(":libvt_generate_stubs") ] + get_target_outputs(":libvt_generate_stubs")
sources -= [ "plugin_list_posix.cc" ] sources -= [ "plugin_list_posix.cc" ]
...@@ -224,11 +219,7 @@ source_set("common") { ...@@ -224,11 +219,7 @@ source_set("common") {
"//third_party/WebKit/public:resources", "//third_party/WebKit/public:resources",
"//ui/accelerated_widget_mac", "//ui/accelerated_widget_mac",
] ]
libs += [ libs += [ "QuartzCore.framework" ]
"IOSurface.framework",
"OpenGL.framework",
"QuartzCore.framework",
]
} }
if (is_android) { if (is_android) {
......
...@@ -165,14 +165,6 @@ source_set("service_sources") { ...@@ -165,14 +165,6 @@ source_set("service_sources") {
] ]
} }
if (is_mac) {
# Required by gles2_cmd_decoder.cc on Mac.
libs = [
"IOSurface.framework",
"OpenGL.framework",
]
}
if (is_android && !is_debug) { if (is_android && !is_debug) {
# On Android optimize more since this component can be a bottleneck. # On Android optimize more since this component can be a bottleneck.
configs -= [ "//build/config/compiler:optimize" ] configs -= [ "//build/config/compiler:optimize" ]
......
...@@ -142,15 +142,6 @@ ...@@ -142,15 +142,6 @@
'../third_party/khronos', '../third_party/khronos',
], ],
}], }],
['OS=="mac"', {
# Required by gles2_cmd_decoder.cc on Mac.
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/IOSurface.framework',
'$(SDKROOT)/System/Library/Frameworks/OpenGL.framework',
],
},
}],
['OS in ("win", "android") or (OS == "linux" and use_x11 == 1)', { ['OS in ("win", "android") or (OS == "linux" and use_x11 == 1)', {
'sources': [ 'sources': [
'command_buffer/service/async_pixel_transfer_manager_egl.cc', 'command_buffer/service/async_pixel_transfer_manager_egl.cc',
......
...@@ -682,10 +682,6 @@ test("media_unittests") { ...@@ -682,10 +682,6 @@ test("media_unittests") {
"midi/midi_manager_mac_unittest.cc", "midi/midi_manager_mac_unittest.cc",
"video/capture/mac/video_capture_device_factory_mac_unittest.mm", "video/capture/mac/video_capture_device_factory_mac_unittest.mm",
] ]
libs = [
# Required by midi_manager_mac_unittest.cc.
"CoreMIDI.framework",
]
} }
if (use_alsa) { if (use_alsa) {
......
...@@ -241,11 +241,6 @@ source_set("base") { ...@@ -241,11 +241,6 @@ source_set("base") {
] ]
} else if (is_mac) { } else if (is_mac) {
sources += [ "user_input_monitor_mac.cc" ] sources += [ "user_input_monitor_mac.cc" ]
# Required by video_frame.cc.
libs = [
"CoreVideo.framework"
]
} else if (is_win) { } else if (is_win) {
sources += [ "user_input_monitor_win.cc" ] sources += [ "user_input_monitor_win.cc" ]
} else { } else {
......
...@@ -20,10 +20,6 @@ source_set("mac") { ...@@ -20,10 +20,6 @@ source_set("mac") {
"avfoundation_glue.h", "avfoundation_glue.h",
"avfoundation_glue.mm", "avfoundation_glue.mm",
] ]
libs = [
# Required by video_frame_mac.cc.
"CoreVideo.framework",
]
} }
set_sources_assignment_filter(sources_assignment_filter) set_sources_assignment_filter(sources_assignment_filter)
configs += [ "//media:media_config" ] configs += [ "//media:media_config" ]
......
...@@ -163,25 +163,12 @@ source_set("sender") { ...@@ -163,25 +163,12 @@ source_set("sender") {
] ]
} }
libs = []
# iOS and OS X encoders # iOS and OS X encoders
if (is_ios || is_mac) { if (is_ios || is_mac) {
sources += [ sources += [
"sender/h264_vt_encoder.cc", "sender/h264_vt_encoder.cc",
"sender/h264_vt_encoder.h", "sender/h264_vt_encoder.h",
] ]
libs += [
"CoreVideo.framework",
]
}
if (is_mac) {
# Required by audio_encoder.cc.
libs += [
"AudioToolbox.framework",
]
} }
} }
......
...@@ -199,19 +199,7 @@ ...@@ -199,19 +199,7 @@
'sender/h264_vt_encoder.cc', 'sender/h264_vt_encoder.cc',
'sender/h264_vt_encoder.h', 'sender/h264_vt_encoder.h',
], ],
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/CoreVideo.framework',
],
},
}], # OS=="ios" or OS=="mac" }], # OS=="ios" or OS=="mac"
['OS=="mac"', {
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/AudioToolbox.framework',
],
},
}], # OS=="mac"
], # conditions ], # conditions
}, },
{ {
......
...@@ -421,13 +421,6 @@ source_set("sync_core") { ...@@ -421,13 +421,6 @@ source_set("sync_core") {
deps += [ "//chromeos" ] deps += [ "//chromeos" ]
} }
if (is_mac) {
libs = [
# Required by get_session_name_mac.mm on Mac.
"SystemConfiguration.framework",
]
}
defines = [ "SYNC_IMPLEMENTATION" ] defines = [ "SYNC_IMPLEMENTATION" ]
configs += [ "//build/config/compiler:wexit_time_destructors" ] configs += [ "//build/config/compiler:wexit_time_destructors" ]
} }
......
...@@ -461,14 +461,6 @@ ...@@ -461,14 +461,6 @@
'../chromeos/chromeos.gyp:chromeos', '../chromeos/chromeos.gyp:chromeos',
], ],
}], }],
['OS=="mac"', {
'link_settings': {
'libraries': [
# Required by get_session_name_mac.mm on Mac.
'$(SDKROOT)/System/Library/Frameworks/SystemConfiguration.framework',
]
},
}],
], ],
}, },
{ {
......
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
source_set("sudden_motion_sensor") {
sources = [
"sudden_motion_sensor_mac.cc",
"sudden_motion_sensor_mac.h",
]
deps = [
"//base",
]
}
...@@ -27,15 +27,9 @@ component("accelerated_widget_mac") { ...@@ -27,15 +27,9 @@ component("accelerated_widget_mac") {
"//skia", "//skia",
"//ui/base", "//ui/base",
"//ui/events", "//ui/events",
"//ui/events:events_base",
"//ui/gfx/geometry", "//ui/gfx/geometry",
"//ui/gl", "//ui/gl",
] ]
libs = [ libs = [ "QuartzCore.framework" ]
# Required by io_surface_texture.mm.
"IOSurface.framework",
"OpenGL.framework",
"QuartzCore.framework",
]
} }
...@@ -39,9 +39,6 @@ ...@@ -39,9 +39,6 @@
], ],
'link_settings': { 'link_settings': {
'libraries': [ 'libraries': [
# Required by io_surface_texture.mm.
'$(SDKROOT)/System/Library/Frameworks/IOSurface.framework',
'$(SDKROOT)/System/Library/Frameworks/OpenGL.framework',
'$(SDKROOT)/System/Library/Frameworks/QuartzCore.framework', '$(SDKROOT)/System/Library/Frameworks/QuartzCore.framework',
], ],
}, },
......
...@@ -27,12 +27,4 @@ component("surface") { ...@@ -27,12 +27,4 @@ component("surface") {
"//ui/gfx/geometry", "//ui/gfx/geometry",
"//ui/gl", "//ui/gl",
] ]
if (is_mac) {
# Required by accelerated_surface_mac.cc.
libs = [
"IOSurface.framework",
"OpenGL.framework",
]
}
} }
...@@ -14,11 +14,9 @@ ...@@ -14,11 +14,9 @@
], ],
}], }],
['OS == "mac"', { ['OS == "mac"', {
# Required by accelerated_surface_mac.cc.
'link_settings': { 'link_settings': {
'libraries': [ 'libraries': [
'$(SDKROOT)/System/Library/Frameworks/IOSurface.framework', '$(SDKROOT)/System/Library/Frameworks/IOSurface.framework',
'$(SDKROOT)/System/Library/Frameworks/OpenGL.framework',
], ],
}, },
}], }],
......
...@@ -119,10 +119,6 @@ component("views") { ...@@ -119,10 +119,6 @@ component("views") {
if (is_mac) { if (is_mac) {
deps += [ "//ui/accelerated_widget_mac" ] deps += [ "//ui/accelerated_widget_mac" ]
libs = [
# Required by bridged_native_widget.mm.
"QuartzCore.framework",
]
} }
} }
......
...@@ -726,12 +726,6 @@ ...@@ -726,12 +726,6 @@
'dependencies': [ 'dependencies': [
'../accelerated_widget_mac/accelerated_widget_mac.gyp:accelerated_widget_mac', '../accelerated_widget_mac/accelerated_widget_mac.gyp:accelerated_widget_mac',
], ],
'link_settings': {
'libraries': [
# Required by bridged_native_widget.mm.
'$(SDKROOT)/System/Library/Frameworks/QuartzCore.framework',
],
},
}], }],
], ],
}, # target_name: views }, # target_name: views
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment