Commit fe50e76f authored by lgarron's avatar lgarron Committed by Commit bot

Switch Fizzy //components to use SchemeIsCryptographic() instead of SchemeIsSecure().

We recently introduced SchemeIsCryptographic() and IsOriginSecure(),
which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214

Review URL: https://codereview.chromium.org/1128363006

Cr-Commit-Position: refs/heads/master@{#329269}
parent 988c697a
...@@ -115,7 +115,7 @@ TEST(WalletServiceUrl, IsUsingProd) { ...@@ -115,7 +115,7 @@ TEST(WalletServiceUrl, IsUsingProd) {
} }
TEST(WalletServiceUrl, IsSignInContinueUrl) { TEST(WalletServiceUrl, IsSignInContinueUrl) {
EXPECT_TRUE(GetSignInContinueUrl().SchemeIsSecure()); EXPECT_TRUE(GetSignInContinueUrl().SchemeIsCryptographic());
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
command_line->AppendSwitchASCII(switches::kWalletServiceUseSandbox, "1"); command_line->AppendSwitchASCII(switches::kWalletServiceUseSandbox, "1");
......
...@@ -659,7 +659,7 @@ bool HostContentSettingsMap::ShouldAllowAllContent( ...@@ -659,7 +659,7 @@ bool HostContentSettingsMap::ShouldAllowAllContent(
#endif #endif
if (secondary_url.SchemeIs(kChromeUIScheme) && if (secondary_url.SchemeIs(kChromeUIScheme) &&
content_type == CONTENT_SETTINGS_TYPE_COOKIES && content_type == CONTENT_SETTINGS_TYPE_COOKIES &&
primary_url.SchemeIsSecure()) { primary_url.SchemeIsCryptographic()) {
return true; return true;
} }
#if defined(ENABLE_EXTENSIONS) #if defined(ENABLE_EXTENSIONS)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment