Commit fe66d5d5 authored by pdr@chromium.org's avatar pdr@chromium.org

Cleanup two trivial PaintOffset bugs in prep for caching paint offset

This is a trivial patch, split off from https://codereview.chromium.org/1315993004.
This patch removes an incorrect "paintOffset" name and fixes the recorder
type in BlockFlowPainter.

Review URL: https://codereview.chromium.org/1316883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201284 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent d37d9253
...@@ -65,7 +65,7 @@ void BlockFlowPainter::paintSelection(const PaintInfo& paintInfo, const LayoutPo ...@@ -65,7 +65,7 @@ void BlockFlowPainter::paintSelection(const PaintInfo& paintInfo, const LayoutPo
// Only create a DrawingRecorder and ClipScope if skipRecording is false. This logic is needed // Only create a DrawingRecorder and ClipScope if skipRecording is false. This logic is needed
// because selectionGaps(...) needs to be called even when we do not record. // because selectionGaps(...) needs to be called even when we do not record.
bool skipRecording = LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutBlockFlow, DisplayItem::SelectionGap); bool skipRecording = LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutBlockFlow, DisplayItem::SelectionGap);
Optional<DrawingRecorder> drawingRecorder; Optional<LayoutObjectDrawingRecorder> drawingRecorder;
Optional<ClipScope> clipScope; Optional<ClipScope> clipScope;
if (!skipRecording) { if (!skipRecording) {
drawingRecorder.emplace(*paintInfo.context, m_layoutBlockFlow, DisplayItem::SelectionGap, FloatRect(bounds)); drawingRecorder.emplace(*paintInfo.context, m_layoutBlockFlow, DisplayItem::SelectionGap, FloatRect(bounds));
......
...@@ -19,7 +19,7 @@ public: ...@@ -19,7 +19,7 @@ public:
void paint(const PaintInfo&, const LayoutPoint& paintOffset); void paint(const PaintInfo&, const LayoutPoint& paintOffset);
void paintReplaced(const PaintInfo&, const LayoutPoint& paintOffset); void paintReplaced(const PaintInfo&, const LayoutPoint& paintOffset);
void paintIntoRect(GraphicsContext*, const LayoutRect& paintOffset); void paintIntoRect(GraphicsContext*, const LayoutRect&);
private: private:
void paintAreaElementFocusRing(const PaintInfo&); void paintAreaElementFocusRing(const PaintInfo&);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment