Commit fe76fe31 authored by Jonathan Ross's avatar Jonathan Ross Committed by Chromium LUCI CQ

Revert "gpu: Ensure consistent GrContextOptions between GPU and OOPR."

This reverts commit cbce6f73.

Reason for revert: 

This change has caused skia_renderer_gl_blink_web_tests and vulkan_native_blink_web_tests to consistenly fail on both Nvidia and Intel Vulkan GPU builders.

It could be that the failures are expected/acceptable image diffs, and new baselines are needed. However this should be manually checked in case there are bugs being introduced/uncovered.

Dry runs can be manually triggered vs 'gpu-fyi-try-linux-nvidia-skv' and 'gpu-fyi-try-linux-intel-skv'

As the bots have been failing consistently I'm reverting so we don't mask other failures.

First failing build

https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20(NVIDIA)/31309/overview




Original change's description:
> gpu: Ensure consistent GrContextOptions between GPU and OOPR.
>
> R=​bsalomon@google.com
>
> Change-Id: I72615b36891e9e5ee568a8332bf0b6344b8188da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545684
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Cr-Commit-Position: refs/heads/master@{#836396}

TBR=bsalomon@google.com,reed@google.com,khushalsagar@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7fe40b0bfdac2053b868e0b4bc78218a938d07b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590057Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836662}
parent be2561be
...@@ -349,8 +349,8 @@ GpuServiceImpl::GpuServiceImpl( ...@@ -349,8 +349,8 @@ GpuServiceImpl::GpuServiceImpl(
protected_buffer_manager_ = new arc::ProtectedBufferManager(); protected_buffer_manager_ = new arc::ProtectedBufferManager();
#endif // BUILDFLAG(IS_CHROMEOS_ASH) #endif // BUILDFLAG(IS_CHROMEOS_ASH)
GrContextOptions context_options = GetDefaultGrContextOptions( GrContextOptions context_options =
gpu_preferences_.gr_context_type, gpu_preferences_); GetDefaultGrContextOptions(gpu_preferences_.gr_context_type);
if (gpu_preferences_.force_max_texture_size) { if (gpu_preferences_.force_max_texture_size) {
context_options.fMaxTextureSizeOverride = context_options.fMaxTextureSizeOverride =
gpu_preferences_.force_max_texture_size; gpu_preferences_.force_max_texture_size;
......
...@@ -270,8 +270,7 @@ bool SharedContextState::InitializeGrContext( ...@@ -270,8 +270,7 @@ bool SharedContextState::InitializeGrContext(
// affect text rendering, make sure to match the capabilities initialized // affect text rendering, make sure to match the capabilities initialized
// in GetCapabilities and ensuring these are also used by the // in GetCapabilities and ensuring these are also used by the
// PaintOpBufferSerializer. // PaintOpBufferSerializer.
GrContextOptions options = GrContextOptions options = GetDefaultGrContextOptions(gr_context_type_);
GetDefaultGrContextOptions(gr_context_type_, gpu_preferences);
options.fPersistentCache = cache; options.fPersistentCache = cache;
options.fShaderErrorHandler = this; options.fShaderErrorHandler = this;
if (gpu_preferences.force_max_texture_size) if (gpu_preferences.force_max_texture_size)
......
...@@ -71,8 +71,7 @@ void DeleteSkObject(SharedContextState* context_state, sk_sp<T> sk_object) { ...@@ -71,8 +71,7 @@ void DeleteSkObject(SharedContextState* context_state, sk_sp<T> sk_object) {
} // namespace } // namespace
GrContextOptions GetDefaultGrContextOptions(GrContextType type, GrContextOptions GetDefaultGrContextOptions(GrContextType type) {
const GpuPreferences& gpu_prefs) {
// If you make any changes to the GrContext::Options here that could affect // If you make any changes to the GrContext::Options here that could affect
// text rendering, make sure to match the capabilities initialized in // text rendering, make sure to match the capabilities initialized in
// GetCapabilities and ensuring these are also used by the // GetCapabilities and ensuring these are also used by the
...@@ -94,11 +93,6 @@ GrContextOptions GetDefaultGrContextOptions(GrContextType type, ...@@ -94,11 +93,6 @@ GrContextOptions GetDefaultGrContextOptions(GrContextType type,
base::CommandLine::ForCurrentProcess()->HasSwitch( base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableMipmapGeneration); switches::kDisableMipmapGeneration);
options.fAllowPathMaskCaching = false;
// TODO(penghuang) : Use this consistently for swiftshader vulkan backend.
options.fSharpenMipmappedTextures =
gpu_prefs.use_vulkan != VulkanImplementationName::kSwiftshader;
return options; return options;
} }
......
...@@ -46,7 +46,7 @@ class SharedContextState; ...@@ -46,7 +46,7 @@ class SharedContextState;
// Returns default GrContextOptions. // Returns default GrContextOptions.
GPU_GLES2_EXPORT GrContextOptions GPU_GLES2_EXPORT GrContextOptions
GetDefaultGrContextOptions(GrContextType type, const GpuPreferences& gpu_prefs); GetDefaultGrContextOptions(GrContextType type);
// Returns internal gl format of texture for Skia // Returns internal gl format of texture for Skia
GPU_GLES2_EXPORT GLuint GPU_GLES2_EXPORT GLuint
......
This is a testharness.js-based test.
PASS can detect same-origin iframe events in parent
PASS can detect same-origin iframe events in subframe
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment