ServiceWorker: Update IDLs to use ScalarValueString

Based on the IDLs in the SW spec and now Fetch spec, use
ScalarValueString as appropriate.

Also, add cases to the overload resolution implementation for ByteString
(and ScalarValueString, though the spec hasn't caught up yet).

R=nbarth@chromium.org,haraken@chromium.org,horo@chromium.org
BUG=379009

Review URL: https://codereview.chromium.org/340943002

git-svn-id: svn://svn.chromium.org/blink/trunk@176531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/request-worker.js

@@ -22,6 +22,10 @@ test(function() {
 
     request.url = 'http://localhost/';
     assert_equals(request.url, 'http://localhost/', 'Request.url should be writable');
+    request.url = 'http://localhost/\uD800'; // Unmatched lead surrogate.
+    assert_equals(request.url,
+                  'http://localhost/' + encodeURIComponent('\uFFFD'),
+                  'Request.url should have unmatched surrogates replaced.');
     request.method = 'POST';
     assert_equals(request.method, 'POST', 'Request.method should be writable');
     assert_throws({name: 'TypeError'}, function() { request.method = 'invalid \u0100'; },

third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -761,9 +761,14 @@ def resolution_tests_methods(effective_overloads):
     # types at position i of its type list,
     # • DOMString
     # • an enumeration type
+    # * ByteString
+    # Blink: ScalarValueString is a pending Web IDL addition
     try:
         method = next(method for idl_type, method in idl_types_methods
-                      if idl_type.name == 'String' or idl_type.is_enum)
+                      if idl_type.name in ('String',
+                                           'ByteString',
+                                           'ScalarValueString') or
+                      idl_type.is_enum)
         yield 'true', method
     except StopIteration:
         pass

third_party/WebKit/Source/modules/serviceworkers/Client.idl

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#client-interface
 [
     Exposed=ServiceWorker,
     RuntimeEnabled=ServiceWorker

third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#fetch-event-interface
 [
     RuntimeEnabled=ServiceWorker,
     Exposed=ServiceWorker

third_party/WebKit/Source/modules/serviceworkers/HeaderMap.idl

@@ -2,7 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#header-map-interface
+// http://fetch.spec.whatwg.org/#headers-class
+// FIXME: Fetch spec has renamed this to just 'Headers'
 // FIXME: This should be defined as MapClass(DOMString, DOMString)
 // once binding code supports it (http://crbug.com/347435).
 [

third_party/WebKit/Source/modules/serviceworkers/InstallEvent.idl

@@ -28,6 +28,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#install-event-interface
 [
     RuntimeEnabled=ServiceWorker,
     Exposed=ServiceWorker,

third_party/WebKit/Source/modules/serviceworkers/InstallPhaseEvent.idl

@@ -28,6 +28,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#install-phase-event-interface
 [
     RuntimeEnabled=ServiceWorker,
     Exposed=ServiceWorker,

third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.idl

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#navigator-service-worker
 [
     RuntimeEnabled=ServiceWorker,
 ] partial interface Navigator {

third_party/WebKit/Source/modules/serviceworkers/RegistrationOptionList.h

@@ -13,6 +13,7 @@ struct RegistrationOptionList  {
     explicit RegistrationOptionList(const Dictionary& options)
         : scope("*")
     {
+        // FIXME: Should be ScalarValueString. http://crbug.com/379009
         options.get("scope", scope);
     }
 

third_party/WebKit/Source/modules/serviceworkers/Request.idl

@@ -2,14 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#request-objects
-
+// http://fetch.spec.whatwg.org/#request-class
 [
     Constructor(optional Dictionary requestInitDict),
     RuntimeEnabled=ServiceWorker,
     Exposed=ServiceWorker
 ] interface Request {
-    attribute DOMString url;
+    attribute ScalarValueString url;
     attribute ByteString method;
     readonly attribute DOMString origin;
     readonly attribute HeaderMap headers;

third_party/WebKit/Source/modules/serviceworkers/Response.idl

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#response-objects
+// http://fetch.spec.whatwg.org/#response-class
 // FIXME: Split this idl/impl into AbstractResponse and Response.
 [
     // FIXME: Add ctors for String, Stream, and ArrayBuffer/ArrayBufferView response bodies.

third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.idl

@@ -27,6 +27,8 @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-interface
 [
     ActiveDOMObject,
     RuntimeEnabled=ServiceWorker
@@ -35,8 +37,9 @@
     // FIXME: Should inherit this from Worker.
     [Custom, RaisesException] void postMessage(SerializedScriptValue message, optional MessagePort[] messagePorts);
 
-    readonly attribute DOMString scope;
-    readonly attribute DOMString url;
+    readonly attribute ScalarValueString scope;
+    readonly attribute ScalarValueString url;
+    // FIXME: Should be ServiceWorkerState enum, not DOMString.
     readonly attribute DOMString state;
     attribute EventHandler onstatechange;
 };

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.idl

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-clients-interface
 [
     Exposed=ServiceWorker,
     RuntimeEnabled=ServiceWorker

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl

@@ -28,6 +28,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container-interface
 [
     RuntimeEnabled=ServiceWorker
 ] interface ServiceWorkerContainer {
@@ -38,6 +39,6 @@
 
     [CallWith=ScriptState] readonly attribute Promise ready;
 
-    [CallWith=ScriptState, ImplementedAs=registerServiceWorker] Promise register(DOMString url, optional Dictionary options);
-    [CallWith=ScriptState, ImplementedAs=unregisterServiceWorker] Promise unregister(optional DOMString scope);
+    [CallWith=ScriptState, ImplementedAs=registerServiceWorker] Promise register(ScalarValueString url, optional Dictionary options);
+    [CallWith=ScriptState, ImplementedAs=unregisterServiceWorker] Promise unregister(ScalarValueString scope);
 };

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl

@@ -27,6 +27,8 @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-global-scope-interface
 [
     Exposed=ServiceWorker,
     Global=Worker&ServiceWorker,
@@ -34,9 +36,9 @@
 ] interface ServiceWorkerGlobalScope : WorkerGlobalScope {
 
   readonly attribute ServiceWorkerClients clients;
-  [CallWith=ExecutionContext, Unforgeable] readonly attribute DOMString scope;
+  [CallWith=ExecutionContext, Unforgeable] readonly attribute ScalarValueString scope;
 
-  [CallWith=ScriptState] Promise fetch(DOMString request);
+  [CallWith=ScriptState] Promise fetch(ScalarValueString request);
   [CallWith=ScriptState] Promise fetch(Request request);
 
   attribute EventHandler onactivate;