Commit fe89ad8c authored by kcarattini's avatar kcarattini Committed by Commit bot

Moves the hotwording checkbox back to the 'Privacy' section.

The hotwording checkbox was moved from the 'Privacy' section
of the settings page in https://codereview.chromium.org/382123004/

This cl moves it back to the 'Privacy' section and shows and hides
the 'Voice' section according to the enable-experimental-hotwording flag.

BUG=407893

Review URL: https://codereview.chromium.org/523573004

Cr-Commit-Position: refs/heads/master@{#292857}
parent b2ab0060
...@@ -154,22 +154,6 @@ ...@@ -154,22 +154,6 @@
<section> <section>
<h3 id="voice-section-title" i18n-content="sectionTitleVoice" hidden></h3> <h3 id="voice-section-title" i18n-content="sectionTitleVoice" hidden></h3>
<div id="voice-section-content"> <div id="voice-section-content">
<div id="hotword-search" hidden>
<div class="checkbox">
<span class="controlled-setting-with-label">
<input id="hotword-search-enable" pref="hotword.search_enabled_2"
metric="Options_HotwordCheckbox" type="checkbox" dialog-pref>
<span>
<label for="hotword-search-enable"
i18n-values=".innerHTML:hotwordSearchEnable">
</label>
<span id="hotword-search-setting-indicator"
pref="hotword.search_enabled_2" dialog-pref>
</span>
</span>
</span>
</div>
</div>
<div id="hotword-always-on-search" hidden> <div id="hotword-always-on-search" hidden>
<div class="checkbox"> <div class="checkbox">
<span class="controlled-setting-with-label"> <span class="controlled-setting-with-label">
...@@ -453,6 +437,22 @@ ...@@ -453,6 +437,22 @@
</span> </span>
</div> </div>
</if> </if>
<div id="hotword-search" hidden>
<div class="checkbox">
<span class="controlled-setting-with-label">
<input id="hotword-search-enable" pref="hotword.search_enabled_2"
metric="Options_HotwordCheckbox" type="checkbox" dialog-pref>
<span>
<label for="hotword-search-enable"
i18n-values=".innerHTML:hotwordSearchEnable">
</label>
<span id="hotword-search-setting-indicator"
pref="hotword.search_enabled_2" dialog-pref>
</span>
</span>
</span>
</div>
</div>
</div> </div>
</section> </section>
<if expr="chromeos"> <if expr="chromeos">
......
...@@ -1100,7 +1100,6 @@ cr.define('options', function() { ...@@ -1100,7 +1100,6 @@ cr.define('options', function() {
* @private * @private
*/ */
showHotwordSection_: function(opt_enabled, opt_error) { showHotwordSection_: function(opt_enabled, opt_error) {
$('voice-section-title').hidden = false;
$('hotword-search').hidden = false; $('hotword-search').hidden = false;
$('hotword-search-setting-indicator').setError(opt_error); $('hotword-search-setting-indicator').setError(opt_error);
if (opt_enabled && opt_error) if (opt_enabled && opt_error)
...@@ -1113,6 +1112,7 @@ cr.define('options', function() { ...@@ -1113,6 +1112,7 @@ cr.define('options', function() {
* @private * @private
*/ */
showHotwordAlwaysOnSection_: function() { showHotwordAlwaysOnSection_: function() {
$('voice-section-title').hidden = false;
$('hotword-always-on-search').hidden = false; $('hotword-always-on-search').hidden = false;
$('audio-logging').hidden = false; $('audio-logging').hidden = false;
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment