[iOS] Rename ToolbarSearchButton to NewTab

The button is no longer used for search, it is now used for opening new
tab.

Fixed: 974751
Change-Id: I7de359e3c8801ec3f936a19cdb6b16358a48c47e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106851
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752401}

ios/chrome/browser/ui/toolbar/buttons/BUILD.gn

@@ -15,8 +15,8 @@ source_set("buttons") {
     "toolbar_component_options.h",
     "toolbar_configuration.h",
     "toolbar_configuration.mm",
-    "toolbar_search_button.h",
-    "toolbar_search_button.mm",
+    "toolbar_new_tab_button.h",
+    "toolbar_new_tab_button.mm",
     "toolbar_style.h",
     "toolbar_tab_grid_button.h",
     "toolbar_tab_grid_button.mm",

ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm

@@ -9,7 +9,7 @@
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_button_actions_handler.h"
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_button_visibility_configuration.h"
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h"
-#import "ios/chrome/browser/ui/toolbar/buttons/toolbar_search_button.h"
+#import "ios/chrome/browser/ui/toolbar/buttons/toolbar_new_tab_button.h"
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.h"
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.h"
 #import "ios/chrome/browser/ui/toolbar/public/features.h"
@@ -169,9 +169,8 @@
 }
 
 - (ToolbarButton*)openNewTabButton {
-  UIImage* buttonImage = [UIImage imageNamed:@"toolbar_new_tab_page"];
-  ToolbarSearchButton* newTabButton =
-      [ToolbarSearchButton toolbarButtonWithImage:buttonImage];
+  ToolbarNewTabButton* newTabButton = [ToolbarNewTabButton
+      toolbarButtonWithImage:[UIImage imageNamed:@"toolbar_new_tab_page"]];
 
   [newTabButton addTarget:self.actionHandler
                    action:@selector(searchAction:)

ios/chrome/browser/ui/toolbar/buttons/toolbar_search_button.h → ios/chrome/browser/ui/toolbar/buttons/toolbar_new_tab_button.h

@@ -2,16 +2,15 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef IOS_CHROME_BROWSER_UI_TOOLBAR_BUTTONS_TOOLBAR_SEARCH_BUTTON_H_
-#define IOS_CHROME_BROWSER_UI_TOOLBAR_BUTTONS_TOOLBAR_SEARCH_BUTTON_H_
+#ifndef IOS_CHROME_BROWSER_UI_TOOLBAR_BUTTONS_TOOLBAR_NEW_TAB_BUTTON_H_
+#define IOS_CHROME_BROWSER_UI_TOOLBAR_BUTTONS_TOOLBAR_NEW_TAB_BUTTON_H_
 
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_button.h"
 
-// TODO(crbug.com/974751): Rename this as the button is no longer for search.
-// Toolbar button used to display the search button with a pill-shaped
+// Toolbar button used to display the new tab button with a circle-shaped
 // background view which is also used as the spotlight view.
-@interface ToolbarSearchButton : ToolbarButton
+@interface ToolbarNewTabButton : ToolbarButton
 
 @end
 
-#endif  // IOS_CHROME_BROWSER_UI_TOOLBAR_BUTTONS_TOOLBAR_SEARCH_BUTTON_H_
+#endif  // IOS_CHROME_BROWSER_UI_TOOLBAR_BUTTONS_TOOLBAR_NEW_TAB_BUTTON_H_

ios/chrome/browser/ui/toolbar/buttons/toolbar_search_button.mm → ios/chrome/browser/ui/toolbar/buttons/toolbar_new_tab_button.mm

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#import "ios/chrome/browser/ui/toolbar/buttons/toolbar_search_button.h"
+#import "ios/chrome/browser/ui/toolbar/buttons/toolbar_new_tab_button.h"
 
 #import "ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h"
 #import "ios/chrome/browser/ui/toolbar/public/features.h"
@@ -17,10 +17,10 @@ namespace {
 const CGFloat kSpotlightHeight = 36.0f;
 }  // namespace
 
-@implementation ToolbarSearchButton
+@implementation ToolbarNewTabButton
 
 + (instancetype)toolbarButtonWithImage:(UIImage*)image {
-  ToolbarSearchButton* button = [super toolbarButtonWithImage:image];
+  ToolbarNewTabButton* button = [super toolbarButtonWithImage:image];
   return button;
 }