Commit feafd4af authored by Regan Hsu's avatar Regan Hsu Committed by Commit Bot

[CrOS Settings] Move Personalization strings out of browser strings.

Move strings that belong to OS Settings Personalization section out
of Appearance string section of browser settings string provider, and
into OS settings string provider.

Bug: 967888
Change-Id: Ib96b0635e304a136ebe137916903b6d9ef5bd87f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013497Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734703}
parent 92ed142a
...@@ -200,12 +200,23 @@ void AddA11yStrings(content::WebUIDataSource* html_source) { ...@@ -200,12 +200,23 @@ void AddA11yStrings(content::WebUIDataSource* html_source) {
::switches::kEnableExperimentalAccessibilitySwitchAccessText)); ::switches::kEnableExperimentalAccessibilitySwitchAccessText));
} }
void AddPersonalizationStrings(content::WebUIDataSource* html_source) {
static constexpr webui::LocalizedString kLocalizedStrings[] = {
{"changePictureTitle", IDS_OS_SETTINGS_CHANGE_PICTURE_TITLE},
{"openWallpaperApp", IDS_OS_SETTINGS_OPEN_WALLPAPER_APP},
{"personalizationPageTitle", IDS_OS_SETTINGS_PERSONALIZATION},
{"setWallpaper", IDS_OS_SETTINGS_SET_WALLPAPER},
};
AddLocalizedStringsBulk(html_source, kLocalizedStrings);
}
} // namespace } // namespace
void AddOsLocalizedStrings(content::WebUIDataSource* html_source, void AddOsLocalizedStrings(content::WebUIDataSource* html_source,
Profile* profile, Profile* profile,
content::WebContents* web_contents) { content::WebContents* web_contents) {
AddA11yStrings(html_source); AddA11yStrings(html_source);
AddPersonalizationStrings(html_source);
} }
} // namespace settings } // namespace settings
......
...@@ -566,12 +566,6 @@ void AddAppearanceStrings(content::WebUIDataSource* html_source, ...@@ -566,12 +566,6 @@ void AddAppearanceStrings(content::WebUIDataSource* html_source,
{"changeHomePage", IDS_SETTINGS_CHANGE_HOME_PAGE}, {"changeHomePage", IDS_SETTINGS_CHANGE_HOME_PAGE},
{"themesGalleryUrl", IDS_THEMES_GALLERY_URL}, {"themesGalleryUrl", IDS_THEMES_GALLERY_URL},
{"chooseFromWebStore", IDS_SETTINGS_WEB_STORE}, {"chooseFromWebStore", IDS_SETTINGS_WEB_STORE},
#if defined(OS_CHROMEOS)
{"changePictureTitle", IDS_OS_SETTINGS_CHANGE_PICTURE_TITLE},
{"openWallpaperApp", IDS_OS_SETTINGS_OPEN_WALLPAPER_APP},
{"personalizationPageTitle", IDS_OS_SETTINGS_PERSONALIZATION},
{"setWallpaper", IDS_OS_SETTINGS_SET_WALLPAPER},
#endif
#if defined(OS_LINUX) && !defined(OS_CHROMEOS) #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
{"showWindowDecorations", IDS_SHOW_WINDOW_DECORATIONS}, {"showWindowDecorations", IDS_SHOW_WINDOW_DECORATIONS},
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment