Commit febe3507 authored by takumif's avatar takumif Committed by Commit bot

Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104

Review-Url: https://codereview.chromium.org/2112623002
Cr-Commit-Position: refs/heads/master@{#403314}
parent 2e51cdd0
...@@ -66,6 +66,9 @@ ...@@ -66,6 +66,9 @@
<message name="IDS_MEDIA_ROUTER_HELP" desc="Title of a menu item which, on click, opens a page to the Chromecast help center."> <message name="IDS_MEDIA_ROUTER_HELP" desc="Title of a menu item which, on click, opens a page to the Chromecast help center.">
Help Help
</message> </message>
<message name="IDS_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION" desc="Title of a menu item which, on click, removes the Media Router Action icon from the toolbar.">
Remove icon
</message>
<message name="IDS_MEDIA_ROUTER_REPORT_ISSUE" desc="Title of a menu item which, on click, opens a page to give feedback or report an issue with Chromecast integration."> <message name="IDS_MEDIA_ROUTER_REPORT_ISSUE" desc="Title of a menu item which, on click, opens a page to give feedback or report an issue with Chromecast integration.">
Report an issue Report an issue
</message> </message>
......
...@@ -39,7 +39,7 @@ MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser) ...@@ -39,7 +39,7 @@ MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser)
menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_HELP, menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_HELP,
IDS_MEDIA_ROUTER_HELP); IDS_MEDIA_ROUTER_HELP);
menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION, menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION,
IDS_EXTENSIONS_UNINSTALL); IDS_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION);
menu_model_.AddSeparator(ui::NORMAL_SEPARATOR); menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS) #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_MANAGE_DEVICES, menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_MANAGE_DEVICES,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment