In tests, always send response's body data pipe, even if empty.
After sending: URLLoaderClient::OnReceiveResponse(response_head), not all URLLoader are sending: URLLoaderClient::OnStartLoadingResponseBody(response_body). It even happens to send URLLoaderClient::OnComplete(net::OK) after that, which may confuse the URLLoaderClient. Most URLLoader not sending a response's body datapipe are the one with an empty response. For consistency, always send a response's body datapipe, even if it doesn't contains data. This CL updates every tests not aligned with this. Once every URLLoader and tests are consistent. DCHECK enforcing this will be added. This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 Bug: 826868, 831155 Change-Id: Id3434ea442c93b47bd200d15322cc21cd0c0b89f Reviewed-on: https://chromium-review.googlesource.com/c/1323092Reviewed-by:Evan Stade <estade@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606386}
Showing
Please register or sign in to comment