Clear |name_| and |value_| in spdy::HpackEntry::operator=().
Charlie points out a bug at https://crbug.com/863471#c2: |name_| and |value_| should be cleared if |other| is of LOOKUP type but |*this| is not. This does not cause any leaks or undefined behavior, but is potentially a waste of memory. As much as I would love to remove spdy::HpackEntry::operator=() altogether, this causes the compile to fail on Windows. Somehow assignment operator is needed to put HpackEntry in a std::dequeue. See win_chromium_compile_dbg_ng trybot failures on Patch Set 2. This CL lands server changes 212433946 and 215208407 by bnc. BUG=488484 Change-Id: Ia64c9a50232297f333f587c0d68de650d93f77db Reviewed-on: https://chromium-review.googlesource.com/1252085 Commit-Queue: Bence Béky <bnc@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Reviewed-by:Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595499}
Showing
Please register or sign in to comment