Commit fee14c93 authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Commit Bot

Add crash keys for BufferedBody::OnDataAvailable

We're seeing some OOMs and want to investigate what's happening.

Bug: 1147081
Change-Id: I9101462643783ea2e6fac50357b2c4043c8c808c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528556
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825801}
parent fd004c04
......@@ -165,6 +165,14 @@ class URLLoaderClientImpl::BodyBuffer final
// mojo::DataPipeDrainer::Client
void OnDataAvailable(const void* data, size_t num_bytes) override {
DCHECK(draining_);
SCOPED_CRASH_KEY_NUMBER(OnDataAvailable, buffered_body_bytes,
buffered_body_.size());
SCOPED_CRASH_KEY_NUMBER(OnDataAvailable, remaining_bytes,
bytes_remaining_in_buffer_);
SCOPED_CRASH_KEY_NUMBER(OnDataAvailable, data_bytes, num_bytes);
SCOPED_CRASH_KEY_STRING256(
OnDataAvailable, last_loaded_url,
owner_->last_loaded_url().possibly_invalid_spec());
const auto span =
base::make_span(static_cast<const char*>(data), num_bytes);
buffered_body_.insert(buffered_body_.end(), span.begin(), span.end());
......
......@@ -76,6 +76,8 @@ class CONTENT_EXPORT URLLoaderClientImpl final
mojo::ScopedDataPipeConsumerHandle body) override;
void OnComplete(const network::URLLoaderCompletionStatus& status) override;
const GURL& last_loaded_url() const { return last_loaded_url_; }
private:
class BodyBuffer;
class DeferredMessage;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment