[Extensions MV3] Add an MV3 sanity check suite

Add a test file (currently with a single test) for manifest v3 related
sanity checks, where we can exercise core functionality of extensions
and make sure it works with manifest v3. This isn't intended to replace
more targeted and robust tests for specific features, and instead to
just serve as a suite of end-to-end integration tests.

Currently, the single test is of programmatic script injection with
a service worker-based extension.

Bug: 993912
Change-Id: I35406ac73ab3ea50d152509068191a68b5fccb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754529Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687398}

chrome/browser/extensions/manifest_v3_browsertest.cc

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "components/version_info/channel.h"
+#include "content/public/browser/web_contents.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/features/feature_channel.h"
+#include "extensions/test/extension_test_message_listener.h"
+#include "extensions/test/result_catcher.h"
+#include "extensions/test/test_extension_dir.h"
+#include "net/dns/mock_host_resolver.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
+
+namespace extensions {
+
+class ManifestV3BrowserTest : public ExtensionBrowserTest {
+ public:
+  ManifestV3BrowserTest() {}
+  ~ManifestV3BrowserTest() override {}
+
+  void SetUpOnMainThread() override {
+    ExtensionBrowserTest::SetUpOnMainThread();
+    host_resolver()->AddRule("*", "127.0.0.1");
+    ASSERT_TRUE(embedded_test_server()->Start());
+  }
+
+ private:
+  ScopedCurrentChannel channel_override_{version_info::Channel::UNKNOWN};
+
+  DISALLOW_COPY_AND_ASSIGN(ManifestV3BrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(ManifestV3BrowserTest, ProgrammaticScriptInjection) {
+  constexpr char kManifest[] =
+      R"({
+           "name": "Programmatic Script Injection",
+           "manifest_version": 3,
+           "version": "0.1",
+           "background": {
+             "service_worker": "worker.js"
+           },
+           "permissions": ["tabs"],
+           "host_permissions": ["*://example.com/*"]
+         })";
+  constexpr char kWorker[] =
+      R"(chrome.tabs.onUpdated.addListener(
+             function listener(tabId, changeInfo, tab) {
+           if (changeInfo.status != 'complete')
+             return;
+           let url = new URL(tab.url);
+           if (url.hostname != 'example.com')
+             return;
+           chrome.tabs.onUpdated.removeListener(listener);
+           chrome.tabs.executeScript(
+               tabId,
+               {code: "document.title = 'My New Title'; document.title;"},
+               (results) => {
+                 chrome.test.assertNoLastError();
+                 chrome.test.assertTrue(!!results);
+                 chrome.test.assertEq(1, results.length);
+                 chrome.test.assertEq('My New Title', results[0]);
+                 chrome.test.notifyPass();
+               });
+         });
+         chrome.test.sendMessage('ready');)";
+
+  TestExtensionDir test_dir;
+  test_dir.WriteManifest(kManifest);
+  test_dir.WriteFile(FILE_PATH_LITERAL("worker.js"), kWorker);
+
+  ExtensionTestMessageListener listener("ready", /*will_reply=*/false);
+  // We ignore the manifest warnings on the extension because it includes the
+  // "manifest v3 ain't quite ready yet" warning.
+  // TODO(devlin): We should probably introduce a flag to specifically ignore
+  // *that* warning, but no others.
+  const Extension* extension = LoadExtensionWithFlags(
+      test_dir.UnpackedPath(), kFlagIgnoreManifestWarnings);
+  ASSERT_TRUE(extension);
+  ASSERT_TRUE(listener.WaitUntilSatisfied());
+
+  ResultCatcher catcher;
+  ui_test_utils::NavigateToURL(
+      browser(), embedded_test_server()->GetURL("example.com", "/simple.html"));
+  ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+
+  EXPECT_EQ(base::ASCIIToUTF16("My New Title"),
+            browser()->tab_strip_model()->GetActiveWebContents()->GetTitle());
+}
+
+}  // namespace extensions

chrome/test/BUILD.gn

@@ -1688,6 +1688,7 @@ if (!is_android) {
         "../browser/extensions/isolated_app_browsertest.cc",
         "../browser/extensions/lazy_background_page_apitest.cc",
         "../browser/extensions/lazy_background_page_test_util.h",
+        "../browser/extensions/manifest_v3_browsertest.cc",
         "../browser/extensions/mutation_observers_apitest.cc",
         "../browser/extensions/native_bindings_apitest.cc",
         "../browser/extensions/navigation_observer_browsertest.cc",