Commit fef335a4 authored by Ted Choc's avatar Ted Choc Committed by Commit Bot

[AppMenu] Move histogram from native -> java

The jump across languages seems unnecessary.

Original CL (Dec 14):
https://codereview.chromium.org/763253005/

Introduction of java histogram recording (Jan 15):
https://codereview.chromium.org/794273004

This looks like just a case that was never migrated.

BUG=

Change-Id: Ie6ebacc60afb0ddd46c87b16256f424431bbfd86
Reviewed-on: https://chromium-review.googlesource.com/1108576
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569074}
parent 529b3856
...@@ -16,10 +16,12 @@ import android.widget.ImageButton; ...@@ -16,10 +16,12 @@ import android.widget.ImageButton;
import android.widget.LinearLayout; import android.widget.LinearLayout;
import android.widget.ListView; import android.widget.ListView;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.RecordUserAction; import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.concurrent.TimeUnit;
/** /**
* Handles the drag touch events on AppMenu that start from the menu button. * Handles the drag touch events on AppMenu that start from the menu button.
...@@ -158,7 +160,8 @@ class AppMenuDragHelper { ...@@ -158,7 +160,8 @@ class AppMenuDragHelper {
mAppMenu.dismiss(); mAppMenu.dismiss();
return true; return true;
} else if (eventActionMasked == MotionEvent.ACTION_UP) { } else if (eventActionMasked == MotionEvent.ACTION_UP) {
nativeRecordAppMenuTouchDuration(timeSinceDown); RecordHistogram.recordTimesHistogram(
"WrenchMenu.TouchDuration", timeSinceDown, TimeUnit.MILLISECONDS);
} }
mIsSingleTapCanceled |= timeSinceDown > mTapTimeout; mIsSingleTapCanceled |= timeSinceDown > mTapTimeout;
...@@ -295,6 +298,4 @@ class AppMenuDragHelper { ...@@ -295,6 +298,4 @@ class AppMenuDragHelper {
mScreenVisibleRect.offset(mScreenVisiblePoint[0], mScreenVisiblePoint[1]); mScreenVisibleRect.offset(mScreenVisiblePoint[0], mScreenVisiblePoint[1]);
return mScreenVisibleRect; return mScreenVisibleRect;
} }
private static native void nativeRecordAppMenuTouchDuration(long timeMs);
} }
...@@ -1905,8 +1905,6 @@ jumbo_split_static_library("browser") { ...@@ -1905,8 +1905,6 @@ jumbo_split_static_library("browser") {
"android/android_theme_resources.h", "android/android_theme_resources.h",
"android/app_hooks.cc", "android/app_hooks.cc",
"android/app_hooks.h", "android/app_hooks.h",
"android/appmenu/app_menu_drag_helper.cc",
"android/appmenu/app_menu_drag_helper.h",
"android/background_sync_launcher_android.cc", "android/background_sync_launcher_android.cc",
"android/background_sync_launcher_android.h", "android/background_sync_launcher_android.h",
"android/background_tab_manager.cc", "android/background_tab_manager.cc",
...@@ -4322,7 +4320,6 @@ if (is_android) { ...@@ -4322,7 +4320,6 @@ if (is_android) {
"../android/java/src/org/chromium/chrome/browser/WarmupManager.java", "../android/java/src/org/chromium/chrome/browser/WarmupManager.java",
"../android/java/src/org/chromium/chrome/browser/WebContentsFactory.java", "../android/java/src/org/chromium/chrome/browser/WebContentsFactory.java",
"../android/java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java", "../android/java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java",
"../android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java",
"../android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java", "../android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java",
"../android/java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java", "../android/java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java",
"../android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java", "../android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java",
......
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/metrics/histogram_macros.h"
#include "jni/AppMenuDragHelper_jni.h"
using base::android::JavaParamRef;
// static
void JNI_AppMenuDragHelper_RecordAppMenuTouchDuration(
JNIEnv* env,
const JavaParamRef<jclass>& jcaller,
jlong time_ms) {
UMA_HISTOGRAM_TIMES("WrenchMenu.TouchDuration",
base::TimeDelta::FromMilliseconds(time_ms));
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment