Commit fefb3c34 authored by Toby Huang's avatar Toby Huang Committed by Commit Bot

[Metrics] Re-enable flaky FamilyUserMetricsProviderTest

I was unable to reproduce the flaky failure, which is a DCHECK error
in an unrelated file. I suspect the error is due to daylight savings
time changes. This CL re-enables the flaky tests. I will reassign the
bug to the file owners.

Bug: 1144651
Change-Id: I59224e96031dc27bd6839c43ccc3f7b3b6936431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531015
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826283}
parent 3aed6673
...@@ -117,8 +117,7 @@ class FamilyUserMetricsProviderTest ...@@ -117,8 +117,7 @@ class FamilyUserMetricsProviderTest
base::test::ScopedFeatureList scoped_feature_list_; base::test::ScopedFeatureList scoped_feature_list_;
}; };
// TODO(crbug/1144651): Test disabled due to flaky failures. IN_PROC_BROWSER_TEST_P(FamilyUserMetricsProviderTest, UserCategory) {
IN_PROC_BROWSER_TEST_P(FamilyUserMetricsProviderTest, DISABLED_UserCategory) {
base::HistogramTester histogram_tester; base::HistogramTester histogram_tester;
// Simulate calling ProvideCurrentSessionData() prior to logging in. // Simulate calling ProvideCurrentSessionData() prior to logging in.
// This call should return prematurely. // This call should return prematurely.
...@@ -154,10 +153,10 @@ IN_PROC_BROWSER_TEST_P(FamilyUserMetricsProviderTest, DISABLED_UserCategory) { ...@@ -154,10 +153,10 @@ IN_PROC_BROWSER_TEST_P(FamilyUserMetricsProviderTest, DISABLED_UserCategory) {
INSTANTIATE_TEST_SUITE_P( INSTANTIATE_TEST_SUITE_P(
, ,
FamilyUserMetricsProviderTest, FamilyUserMetricsProviderTest,
testing::Values(FamilyUserMetricsProvider::LogSegment::kSupervisedUser, testing::Values(FamilyUserMetricsProvider::LogSegment::kOther,
FamilyUserMetricsProvider::LogSegment::kSupervisedUser,
FamilyUserMetricsProvider::LogSegment::kSupervisedStudent, FamilyUserMetricsProvider::LogSegment::kSupervisedStudent,
FamilyUserMetricsProvider::LogSegment::kStudentAtHome, FamilyUserMetricsProvider::LogSegment::kStudentAtHome));
FamilyUserMetricsProvider::LogSegment::kOther));
class FamilyUserMetricsProviderGuestModeTest class FamilyUserMetricsProviderGuestModeTest
: public MixinBasedInProcessBrowserTest { : public MixinBasedInProcessBrowserTest {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment