Commit ff053efd authored by Alex Rudenko's avatar Alex Rudenko Committed by Commit Bot

Revert "Propagate color space in DevToolsEyeDropper"

This reverts commit 68b09615.

Reason for revert: after extensive testing, it seems that the fix makes the problem worse

Original change's description:
> Propagate color space in DevToolsEyeDropper
> 
> Sets the color space for DevToolsEyeDropper's bitmap
> 
> Bug: 884170, 1066415
> Change-Id: I2436c326f06dd7d68671cac9ae041fa63c93a60d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207370
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770021}

TBR=yangguo@chromium.org,petermarshall@chromium.org,mathias@chromium.org,alexrudenko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 884170, 1066415
Change-Id: I3eb31f9599e01d214a83563888e44c2332e9a995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228849Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Reviewed-by: default avatarPeter Marshall <petermarshall@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775002}
parent 2fb9ab54
...@@ -182,11 +182,9 @@ void DevToolsEyeDropper::UpdateCursor() { ...@@ -182,11 +182,9 @@ void DevToolsEyeDropper::UpdateCursor() {
host_->GetScreenInfo(&screen_info); host_->GetScreenInfo(&screen_info);
double device_scale_factor = screen_info.device_scale_factor; double device_scale_factor = screen_info.device_scale_factor;
SkImageInfo info = SkImageInfo::MakeN32Premul(
kCursorSize * device_scale_factor, kCursorSize * device_scale_factor,
screen_info.color_space.ToSkColorSpace());
SkBitmap result; SkBitmap result;
result.allocPixels(info); result.allocN32Pixels(kCursorSize * device_scale_factor,
kCursorSize * device_scale_factor);
result.eraseARGB(0, 0, 0, 0); result.eraseARGB(0, 0, 0, 0);
SkCanvas canvas(result); SkCanvas canvas(result);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment