GN build improvements.

Fixes a TODO about private symbols on GCC.

Moves many third party BUILD.gn files from the secondary tree to the main one.

Fixes the dependencies on Linux so "gn check" passes again.

BUG=367595
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/256153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266932 0039d316-1c4b-4281-b951-d872f2087c98

components/translate/BUILD.gn

@@ -33,7 +33,9 @@ static_library("translate_core_browser") {
   deps = [
     ":translate_core_common",
     "//base",
+    "//components/language_usage_metrics",
     "//components/resources:components_resources",
+    "//net",
     "//url",
   ]
 }

net/third_party/nss/ssl/BUILD.gn

@@ -118,8 +118,8 @@ component("libssl") {
     forward_dependent_configs_from = deps
   }
 
-  if (component_mode == "shared_library") {
-    # TODO(brettw) GCC_SYMBOLS_PRIVATE_EXTERN thing.
+  if (!is_win && component_mode == "shared_library") {
+    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
   }
 
   if (is_clang) {

tools/gn/secondary/third_party/expat/BUILD.gn → third_party/expat/BUILD.gn

@@ -11,7 +11,7 @@ if (is_linux) {
     direct_dependent_configs = [ ":expat_config" ]
   }
 
-  # TODO(brettw) Android needs direct dependent includes of
+  # TODO(GYP) Android needs direct dependent includes of
   # <android_src>/external/expat/lib
 } else {
   config("expat_config") {

ui/events/BUILD.gn

@@ -41,6 +41,7 @@ component("events_base") {
     ":dom4_keycode_converter",
     "//base",
     "//base/third_party/dynamic_annotations",
+    "//ui/gfx",
     "//ui/gfx/geometry",
   ]
 

ui/gfx/BUILD.gn

@@ -456,5 +456,10 @@ if (use_x11) {
     ]
 
     configs += [ "//build/config/linux:x11" ]
+
+    deps = [
+      ":gfx_export",
+      "//base"
+    ]
   }
 }