Commit ff251816 authored by Yuke Liao's avatar Yuke Liao Committed by Commit Bot

Disable 3 tests in NewTabPage test case on iOS 11.

testRotation, testOmnibox and testScrollToolbar fail on iPhone 6 Plus,
iOS 10, and this CL disables them on iOS 11 to unblock running the test
case on iPhone 6 Plus, iOS 11.

Bug: 751803
Change-Id: Ibcda582e2f86617b1fcea89a5296dde182b9b81c
Reviewed-on: https://chromium-review.googlesource.com/598646Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491503}
parent fbdce5f5
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#import <EarlGrey/EarlGrey.h> #import <EarlGrey/EarlGrey.h>
#import <XCTest/XCTest.h> #import <XCTest/XCTest.h>
#include "base/ios/ios_util.h"
#include "components/strings/grit/components_strings.h" #include "components/strings/grit/components_strings.h"
#import "ios/chrome/browser/ui/commands/generic_chrome_command.h" #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
#include "ios/chrome/browser/ui/commands/ios_command_ids.h" #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
...@@ -143,6 +144,11 @@ void AssertNTPScrolledToTop(bool scrolledToTop) { ...@@ -143,6 +144,11 @@ void AssertNTPScrolledToTop(bool scrolledToTop) {
EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to device rotation bug."); EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to device rotation bug.");
} }
// TODO(crbug.com/751803): Re-enable this test once the bug is fixed.
if (base::ios::IsRunningOnIOS11OrLater()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iOS 11.")
}
NSString* ntpOmniboxLabel = l10n_util::GetNSString(IDS_OMNIBOX_EMPTY_HINT); NSString* ntpOmniboxLabel = l10n_util::GetNSString(IDS_OMNIBOX_EMPTY_HINT);
NSString* focusedOmniboxLabel = l10n_util::GetNSString(IDS_ACCNAME_LOCATION); NSString* focusedOmniboxLabel = l10n_util::GetNSString(IDS_ACCNAME_LOCATION);
SelectNewTabPagePanel(NewTabPage::kHomePanel); SelectNewTabPagePanel(NewTabPage::kHomePanel);
...@@ -214,6 +220,11 @@ void AssertNTPScrolledToTop(bool scrolledToTop) { ...@@ -214,6 +220,11 @@ void AssertNTPScrolledToTop(bool scrolledToTop) {
// Tests focusing and defocusing the NTP's omnibox. // Tests focusing and defocusing the NTP's omnibox.
- (void)testOmnibox { - (void)testOmnibox {
// TODO(crbug.com/751803): Re-enable this test once the bug is fixed.
if (base::ios::IsRunningOnIOS11OrLater()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iOS 11.")
}
// Empty the pasteboard: if it contains a link the Google Landing will not be // Empty the pasteboard: if it contains a link the Google Landing will not be
// interactable. // interactable.
[UIPasteboard generalPasteboard].string = @""; [UIPasteboard generalPasteboard].string = @"";
...@@ -282,6 +293,11 @@ void AssertNTPScrolledToTop(bool scrolledToTop) { ...@@ -282,6 +293,11 @@ void AssertNTPScrolledToTop(bool scrolledToTop) {
EARL_GREY_TEST_SKIPPED(@"Skipped for iPad (no hidden toolbar in tablet)"); EARL_GREY_TEST_SKIPPED(@"Skipped for iPad (no hidden toolbar in tablet)");
} }
// TODO(crbug.com/751803): Re-enable this test once the bug is fixed.
if (base::ios::IsRunningOnIOS11OrLater()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iOS 11.")
}
NSString* toolsMenuLabel = l10n_util::GetNSString(IDS_IOS_TOOLBAR_SETTINGS); NSString* toolsMenuLabel = l10n_util::GetNSString(IDS_IOS_TOOLBAR_SETTINGS);
// Check that the toolbar's tab switcher and tools menu buttons are visible. // Check that the toolbar's tab switcher and tools menu buttons are visible.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment