Commit ff2e189e authored by Benedikt Meurer's avatar Benedikt Meurer Committed by Commit Bot

[devtools] Label background compiles with "Streaming Compile Script".

Previously background parsing and compilation was always labeled "Parse
Script" whereas foreground parsing and compilation was always labeled
"Compile Script". But in either case the engine might parse and/or
compile, so we should be consistent here. Also for developers it doesn't
really matter whether V8 is parsing or compiling to bytecode.

Bug: chromium:940958
Change-Id: I320095e10613d7cc1405069345e0dd0613a7130a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844993Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Reviewed-by: default avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703258}
parent 8c0fbfa6
...@@ -86,7 +86,8 @@ Timeline.TimelineUIUtils = class { ...@@ -86,7 +86,8 @@ Timeline.TimelineUIUtils = class {
eventStyles[type.EvaluateScript] = new Timeline.TimelineRecordStyle(ls`Evaluate Script`, scripting); eventStyles[type.EvaluateScript] = new Timeline.TimelineRecordStyle(ls`Evaluate Script`, scripting);
eventStyles[type.CompileModule] = new Timeline.TimelineRecordStyle(ls`Compile Module`, scripting); eventStyles[type.CompileModule] = new Timeline.TimelineRecordStyle(ls`Compile Module`, scripting);
eventStyles[type.EvaluateModule] = new Timeline.TimelineRecordStyle(ls`Evaluate Module`, scripting); eventStyles[type.EvaluateModule] = new Timeline.TimelineRecordStyle(ls`Evaluate Module`, scripting);
eventStyles[type.ParseScriptOnBackground] = new Timeline.TimelineRecordStyle(ls`Parse Script`, scripting); eventStyles[type.StreamingCompileScript] =
new Timeline.TimelineRecordStyle(ls`Streaming Compile Script`, scripting);
eventStyles[type.WasmStreamFromResponseCallback] = eventStyles[type.WasmStreamFromResponseCallback] =
new Timeline.TimelineRecordStyle(ls`Streaming Wasm Response`, scripting); new Timeline.TimelineRecordStyle(ls`Streaming Wasm Response`, scripting);
eventStyles[type.WasmCompiledModule] = new Timeline.TimelineRecordStyle(ls`Compiled Wasm Module`, scripting); eventStyles[type.WasmCompiledModule] = new Timeline.TimelineRecordStyle(ls`Compiled Wasm Module`, scripting);
...@@ -533,7 +534,7 @@ Timeline.TimelineUIUtils = class { ...@@ -533,7 +534,7 @@ Timeline.TimelineUIUtils = class {
break; break;
} }
case recordType.ParseScriptOnBackground: case recordType.StreamingCompileScript:
case recordType.XHRReadyStateChange: case recordType.XHRReadyStateChange:
case recordType.XHRLoad: { case recordType.XHRLoad: {
const url = eventData['url']; const url = eventData['url'];
...@@ -697,7 +698,7 @@ Timeline.TimelineUIUtils = class { ...@@ -697,7 +698,7 @@ Timeline.TimelineUIUtils = class {
} }
break; break;
} }
case recordType.ParseScriptOnBackground: { case recordType.StreamingCompileScript: {
const url = eventData['url']; const url = eventData['url'];
if (url) { if (url) {
details = linkifyLocation('', url, 0, 0); details = linkifyLocation('', url, 0, 0);
......
...@@ -214,9 +214,6 @@ Click the reload button <ph name="RELOADBUTTON">$3s<ex>reload</ex></ph> or hit < ...@@ -214,9 +214,6 @@ Click the reload button <ph name="RELOADBUTTON">$3s<ex>reload</ex></ph> or hit <
<message name="IDS_DEVTOOLS_2fc3f5e968c02091e3ba9863088f0651" desc="Text in Timeline UIUtils of the Performance panel"> <message name="IDS_DEVTOOLS_2fc3f5e968c02091e3ba9863088f0651" desc="Text in Timeline UIUtils of the Performance panel">
Callback Function Callback Function
</message> </message>
<message name="IDS_DEVTOOLS_31084046e4a000cc4ac980dc68ea9ce9" desc="Text in Timeline UIUtils of the Performance panel">
Parse Script
</message>
<message name="IDS_DEVTOOLS_316853cc3718335f11c048e33b9be98a" desc="Text in Timeline UIUtils of the Performance panel"> <message name="IDS_DEVTOOLS_316853cc3718335f11c048e33b9be98a" desc="Text in Timeline UIUtils of the Performance panel">
Click Click
</message> </message>
...@@ -520,6 +517,9 @@ Click the reload button <ph name="RELOADBUTTON">$3s<ex>reload</ex></ph> or hit < ...@@ -520,6 +517,9 @@ Click the reload button <ph name="RELOADBUTTON">$3s<ex>reload</ex></ph> or hit <
<message name="IDS_DEVTOOLS_7ac6c415cd08c0ba2c0a1f54c0a62a52" desc="Text in Timeline UIUtils of the Performance panel"> <message name="IDS_DEVTOOLS_7ac6c415cd08c0ba2c0a1f54c0a62a52" desc="Text in Timeline UIUtils of the Performance panel">
''' (from push) ''' (from push)
</message> </message>
<message name="IDS_DEVTOOLS_80a0135dfd4156f542f097a6351c727f" desc="Text in Timeline UIUtils of the Performance panel">
Streaming Compile Script
</message>
<message name="IDS_DEVTOOLS_80a4b8755d836d50c19e6eefb976bc2e" desc="Text in Timeline UIUtils of the Performance panel"> <message name="IDS_DEVTOOLS_80a4b8755d836d50c19e6eefb976bc2e" desc="Text in Timeline UIUtils of the Performance panel">
<ph name="SELFCATEGORY_TITLE">$1s<ex>blink.console</ex></ph> (self) <ph name="SELFCATEGORY_TITLE">$1s<ex>blink.console</ex></ph> (self)
</message> </message>
......
...@@ -1391,7 +1391,7 @@ TimelineModel.TimelineModel.RecordType = { ...@@ -1391,7 +1391,7 @@ TimelineModel.TimelineModel.RecordType = {
V8Sample: 'V8Sample', V8Sample: 'V8Sample',
JitCodeAdded: 'JitCodeAdded', JitCodeAdded: 'JitCodeAdded',
JitCodeMoved: 'JitCodeMoved', JitCodeMoved: 'JitCodeMoved',
ParseScriptOnBackground: 'v8.parseOnBackground', StreamingCompileScript: 'v8.parseOnBackground',
V8Execute: 'V8.Execute', V8Execute: 'V8.Execute',
UpdateCounters: 'UpdateCounters', UpdateCounters: 'UpdateCounters',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment