Commit ff314b9d authored by Trevor David Black's avatar Trevor David Black Committed by Chromium LUCI CQ

Changed glCopyTexture to glCopySubTexture to remove bug in ANGLE

Bug: 172489285
Change-Id: I041c4722f630fa615d7727c2767f08e605032e87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616980Reviewed-by: default avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: default avatarCorentin Wallez <cwallez@chromium.org>
Reviewed-by: default avatarKai Ninomiya <kainino@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842104}
parent aaf359b0
......@@ -182,19 +182,19 @@ SharedImageBackingGLCommon::ProduceDawnCommon(SharedImageFactory* factory,
GLenum target = dst_image->GetTextureBase()->target();
// Ensure skia's internal cache of GL context state is reset before using it.
// TODO(crbug.com/1036142: Figure out cases that need this invocation).
// TODO(crbug.com/1036142): Figure out cases that need this invocation.
shared_context_state->PessimisticallyResetGrContext();
if (use_passthrough) {
gl::GLApi* gl = shared_context_state->context_state()->api();
gl->glCopyTextureCHROMIUMFn(source_texture, 0, target, dest_texture, 0,
viz::GLDataFormat(backing->format()),
viz::GLDataType(backing->format()), false,
false, false);
gl->glCopySubTextureCHROMIUMFn(source_texture, 0, target, dest_texture, 0,
0, 0, 0, 0, dst_image->size().width(),
dst_image->size().height(), false, false,
false);
} else {
// TODO(crbug.com/1036142: Implement copyTextureCHROMIUM for validating
// path).
// TODO(crbug.com/1036142): Implement copyTextureCHROMIUM for validating
// path.
NOTREACHED();
return nullptr;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment