Commit ff7c4824 authored by Camille Lamy's avatar Camille Lamy Committed by Commit Bot

Add a check for FrameNavigationEntry in NavigationRequest creation

This CL adds a temporary check in

that we have a valid FrameNavigationEntry.

NavigationControllerImpl: :CreateNavigationRequestFromLoadParams to check
Bug: 896028, 877654
Change-Id: Iaaf20e3eeb98e4ce284fa6a18a9a75d7d8016c79
Reviewed-on: https://chromium-review.googlesource.com/c/1322875
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606058}
parent 56d26549
...@@ -2734,6 +2734,10 @@ NavigationControllerImpl::CreateNavigationRequestFromLoadParams( ...@@ -2734,6 +2734,10 @@ NavigationControllerImpl::CreateNavigationRequestFromLoadParams(
const NavigationEntryImpl& entry, const NavigationEntryImpl& entry,
FrameNavigationEntry* frame_entry) { FrameNavigationEntry* frame_entry) {
DCHECK_EQ(-1, GetIndexOfEntry(&entry)); DCHECK_EQ(-1, GetIndexOfEntry(&entry));
// TODO(https://crbug.com/896028): Turn this CHECK into a DCHECK once the bug
// is fixed.
CHECK(frame_entry);
GURL url_to_load; GURL url_to_load;
GURL virtual_url; GURL virtual_url;
// For main frames, rewrite the URL if necessary and compute the virtual URL // For main frames, rewrite the URL if necessary and compute the virtual URL
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment