Commit ffb4d2c9 authored by John Abd-El-Malek's avatar John Abd-El-Malek Committed by Commit Bot

Fix SecurityStateTabHelperTest.DefaultSecurityLevelOn*FilesystemUrl tests with network service.

The problem was that empty filesystem objects weren't calling URLLoaderClient::OnReceiveResponse.

Bug: 769401
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I3e9266848642f9fa7d761b605370335441d94511
Reviewed-on: https://chromium-review.googlesource.com/1110275Reviewed-by: default avatarChris Mumford <cmumford@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569627}
parent 75028fa6
...@@ -489,6 +489,11 @@ class FileSystemFileURLLoader : public FileSystemEntryURLLoader { ...@@ -489,6 +489,11 @@ class FileSystemFileURLLoader : public FileSystemEntryURLLoader {
int64_t bytes_to_read = std::min( int64_t bytes_to_read = std::min(
static_cast<int64_t>(kDefaultFileSystemUrlPipeSize), remaining_bytes_); static_cast<int64_t>(kDefaultFileSystemUrlPipeSize), remaining_bytes_);
if (!bytes_to_read) { if (!bytes_to_read) {
if (consumer_handle_.is_valid()) {
// This was an empty file; make sure to call OnReceiveResponse
// regardless.
client_->OnReceiveResponse(head_);
}
OnFileWritten(MOJO_RESULT_OK); OnFileWritten(MOJO_RESULT_OK);
return; return;
} }
......
...@@ -13,10 +13,6 @@ ...@@ -13,10 +13,6 @@
-ProcessManagerBrowserTest.NestedURLNavigationsToExtensionAllowed -ProcessManagerBrowserTest.NestedURLNavigationsToExtensionAllowed
-ProxySettingsApiTest.ProxyEventsInvalidProxy -ProxySettingsApiTest.ProxyEventsInvalidProxy
-RegisterProtocolHandlerBrowserTest.CustomHandler -RegisterProtocolHandlerBrowserTest.CustomHandler
-SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl/0
-SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl/1
-SecurityStateTabHelperTest.DefaultSecurityLevelOnSecureFilesystemUrl/0
-SecurityStateTabHelperTest.DefaultSecurityLevelOnSecureFilesystemUrl/1
-SSLUITest.TestBadHTTPSDownload/0 -SSLUITest.TestBadHTTPSDownload/0
-SSLUITest.TestBadHTTPSDownload/1 -SSLUITest.TestBadHTTPSDownload/1
-SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe -SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment