Commit ffbaa8b3 authored by Chris Lu's avatar Chris Lu Committed by Commit Bot

[ios] Move RemoteTabs additionalSafeAreaInset modification in Tabgrid to during rotation animation

Currently making modifications in the completion block results in flickers during rotations.

Video: https://drive.google.com/open?id=1rtjOugnQaVRqO9mtflrEIgUJ16oipic2

Bug: 878832
Change-Id: Icee69d81199ff068c3ac74a768d0ee4509372826
Reviewed-on: https://chromium-review.googlesource.com/1199931Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588521}
parent e8aaa5ec
...@@ -251,13 +251,9 @@ NSUInteger GetPageIndexFromPage(TabGridPage page) { ...@@ -251,13 +251,9 @@ NSUInteger GetPageIndexFromPage(TabGridPage page) {
// current page value. // current page value.
self.currentPage = _currentPage; self.currentPage = _currentPage;
[self configureViewControllerForCurrentSizeClassesAndPage]; [self configureViewControllerForCurrentSizeClassesAndPage];
[self setInsetForRemoteTabs];
}; };
auto completion = [coordinator animateAlongsideTransition:animate completion:nil];
^(id<UIViewControllerTransitionCoordinatorContext> context) {
// Modify Remote Tabs Insets when page appears and during rotation.
[self setInsetForRemoteTabs];
};
[coordinator animateAlongsideTransition:animate completion:completion];
} }
- (UIStatusBarStyle)preferredStatusBarStyle { - (UIStatusBarStyle)preferredStatusBarStyle {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment