Commit ffbe3d53 authored by bttk's avatar bttk Committed by Commit Bot

[ToolbarMVC] Rename identifiers with "percent" to "fraction"

Only changing files related to ToolbarLayout.

This correction came when moving
LocationBarPhone.setUrlFocusChangePercent to the LocationBar interface.
The move of the method will depend on this change.

Bug: 1133482
Change-Id: I222175e8c39b39a75d87a05a3993d6c3cdae1bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439109
Auto-Submit: who/bttk <bttk@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarPatrick Noland <pnoland@chromium.org>
Commit-Queue: who/bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812906}
parent d55503d4
......@@ -140,14 +140,14 @@ public abstract class ToolbarLayout
}
/**
* @param urlExpansionObserver The observer that observes URL expansion percentage change.
* @param urlExpansionObserver The observer that observes URL expansion progress change.
*/
void addUrlExpansionObserver(UrlExpansionObserver urlExpansionObserver) {
mUrlExpansionObservers.addObserver(urlExpansionObserver);
}
/**
* @param urlExpansionObserver The observer that observes URL expansion percentage change.
* @param urlExpansionObserver The observer that observes URL expansion progress change.
*/
void removeUrlExpansionObserver(UrlExpansionObserver urlExpansionObserver) {
mUrlExpansionObservers.removeObserver(urlExpansionObserver);
......
......@@ -410,9 +410,9 @@ public class ToolbarTablet extends ToolbarLayout
if (mVisibleNtp != null) {
mVisibleNtp.setSearchBoxScrollListener(new NewTabPage.OnSearchBoxScrollListener() {
@Override
public void onNtpScrollChanged(float scrollPercentage) {
public void onNtpScrollChanged(float scrollFraction) {
// Fade the search box out in the first 40% of the scrolling transition.
float alpha = Math.max(1f - scrollPercentage * 2.5f, 0f);
float alpha = Math.max(1f - scrollFraction * 2.5f, 0f);
mVisibleNtp.setSearchBoxAlpha(alpha);
mVisibleNtp.setSearchProviderLogoAlpha(alpha);
}
......
......@@ -44,16 +44,17 @@ import java.util.List;
*/
public class TopToolbarCoordinator implements Toolbar {
/**
* Observes toolbar URL expansion percentage change.
* Observes toolbar URL expansion progress change.
*/
public interface UrlExpansionObserver {
/**
* Notified when toolbar URL expansion percentage changes.
* @param percentage The toolbar expansion percentage. 0 indicates that the URL bar is not
* Notified when toolbar URL expansion progress fraction changes.
*
* @param fraction The toolbar expansion progress. 0 indicates that the URL bar is not
* expanded. 1 indicates that the URL bar is expanded to the maximum
* width.
*/
void onUrlExpansionPercentageChanged(float percentage);
void onUrlExpansionProgressChanged(float fraction);
}
public static final int TAB_SWITCHER_MODE_NORMAL_ANIMATION_DURATION_MS = 200;
......@@ -201,14 +202,14 @@ public class TopToolbarCoordinator implements Toolbar {
}
/**
* @param urlExpansionObserver The observer that observes URL expansion percentage change.
* @param urlExpansionObserver The observer that observes URL expansion progress change.
*/
public void addUrlExpansionObserver(UrlExpansionObserver urlExpansionObserver) {
mToolbarLayout.addUrlExpansionObserver(urlExpansionObserver);
}
/**
* @param urlExpansionObserver The observer that observes URL expansion percentage change.
* @param urlExpansionObserver The observer that observes URL expansion progress change.
*/
public void removeUrlExpansionObserver(UrlExpansionObserver urlExpansionObserver) {
mToolbarLayout.removeUrlExpansionObserver(urlExpansionObserver);
......
......@@ -227,8 +227,8 @@ public class StatusBarColorController
// TopToolbarCoordinator.UrlExpansionObserver implementation.
@Override
public void onUrlExpansionPercentageChanged(float percentage) {
mToolbarUrlExpansionPercentage = percentage;
public void onUrlExpansionProgressChanged(float fraction) {
mToolbarUrlExpansionPercentage = fraction;
if (mShouldUpdateStatusBarColorForNTP) updateStatusBarColor();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment