Commit ffbef589 authored by Artur Khachatryan's avatar Artur Khachatryan Committed by Commit Bot

[ChromeDriver] Drop support for Chrome M65

Change-Id: I0b716112f233b2790ec0ee5af33760438aea9218
Reviewed-on: https://chromium-review.googlesource.com/1054422Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557712}
parent 74a80a86
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
namespace { namespace {
// This variable must be able to be found and parsed by the upload script. // This variable must be able to be found and parsed by the upload script.
const int kMinimumSupportedChromeVersion[] = {65, 0, 3325, 0}; const int kMinimumSupportedChromeVersion[] = {66, 0, 3359, 0};
} // namespace } // namespace
......
...@@ -189,37 +189,22 @@ def main(): ...@@ -189,37 +189,22 @@ def main():
return code return code
else: else:
versions = {'HEAD': archive.GetLatestRevision()} versions = {'HEAD': archive.GetLatestRevision()}
if util.IsLinux() and not util.Is64Bit():
# Linux32 builds need to be special-cased, because 1) they are keyed by
# git hash rather than commit position, and 2) come from a different
# download site (so we can't just convert the commit position to a hash).
versions['63'] = 'adb61db19020ed8ecee5e91b1a0ea4c924ae2988'
versions['62'] = '17030e3a08cfbb6e591991f7dbf0eb703454b365'
versions['61'] = '77132a2bc78e8dc9ce411e8166bfd009f6476f6f'
# TODO(samuong): speculative fix for crbug.com/611886
os.environ['CHROME_DEVEL_SANDBOX'] = '/opt/chromium/chrome_sandbox'
# Linux64 build numbers # Linux64 build numbers
elif util.IsLinux(): if util.IsLinux():
versions['67'] = '550422' versions['67'] = '550422'
versions['66'] = '540276' versions['66'] = '540276'
versions['65'] = '530372'
# Mac build numbers # Mac build numbers
elif util.IsMac(): elif util.IsMac():
versions['67'] = '550418' versions['67'] = '550418'
versions['66'] = '540271' versions['66'] = '540271'
versions['65'] = '530368'
# Windows build numbers # Windows build numbers
elif util.IsWindows(): elif util.IsWindows():
versions['67'] = '550416' versions['67'] = '550416'
versions['66'] = '540272' versions['66'] = '540272'
versions['65'] = '530366'
code = 0 code = 0
for version, revision in versions.iteritems(): for version, revision in versions.iteritems():
......
...@@ -89,14 +89,6 @@ _VERSION_SPECIFIC_FILTER['66'] = [ ...@@ -89,14 +89,6 @@ _VERSION_SPECIFIC_FILTER['66'] = [
'ChromeDriverTest.testSlowIFrame', 'ChromeDriverTest.testSlowIFrame',
] ]
_VERSION_SPECIFIC_FILTER['65'] = [
# https://bugs.chromium.org/p/chromium/issues/detail?id=803678
'ChromeDriverTest.testGoBackAndGoForward',
'ChromeDriverTest.testAlertHandlingOnPageUnload',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2350
'ChromeDriverTest.testSlowIFrame',
]
_OS_SPECIFIC_FILTER = {} _OS_SPECIFIC_FILTER = {}
_OS_SPECIFIC_FILTER['win'] = [ _OS_SPECIFIC_FILTER['win'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=299 # https://bugs.chromium.org/p/chromedriver/issues/detail?id=299
...@@ -2602,11 +2594,6 @@ class RemoteBrowserTest(ChromeDriverBaseTest): ...@@ -2602,11 +2594,6 @@ class RemoteBrowserTest(ChromeDriverBaseTest):
'--remote-debugging-port=%d' % port, '--remote-debugging-port=%d' % port,
'--user-data-dir=%s' % temp_dir, '--user-data-dir=%s' % temp_dir,
'--use-mock-keychain'] '--use-mock-keychain']
if util.IsLinux() and not util.Is64Bit():
# Workaround for crbug.com/611886.
cmd.append('--no-sandbox')
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1695
cmd.append('--disable-gpu')
process = subprocess.Popen(cmd) process = subprocess.Popen(cmd)
if process is None: if process is None:
raise RuntimeError('Chrome could not be started with debugging port') raise RuntimeError('Chrome could not be started with debugging port')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment