Android: Remove some lint suppressions

Add ignores for EditText elements that do not need autofillHints.

Remove ButtonOrder suppression as it's no longer needed.

Bug: 1073966,1116130
Fixed: 1073966

Change-Id: I80c97528c3558379d43677b78bbbc2f290d5105e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419593
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809369}

chrome/android/expectations/lint-suppressions.xml

@@ -18,15 +18,6 @@ Still reading?
     <ignore regexp="chrome/android/java/res_base/xml/network_security_config.xml"/>
     <ignore regexp="android_webview/tools/system_webview_shell/apk/res/xml/network_security_config.xml"/>
   </issue>
-  <issue id="Autofill">
-    <!-- Filed https://crbug.com/1073966 to fix -->
-    <ignore regexp="chrome/android/features/tab_ui/java/res/layout/bottom_tab_grid_toolbar.xml"/>
-    <ignore regexp="chrome/android/java/res/layout/password_entry_editor.xml"/>
-    <ignore regexp="components/browser_ui/widget/android/java/res/layout/radio_button_with_edit_text.xml"/>
-  </issue>
-  <issue id="ButtonOrder">
-    <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/>
-  </issue>
   <issue id="ContentDescription">
     <!--TODO(crbug.com/1044658): This suppression was added blindly, and needs investigated.-->
     <ignore regexp="components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml"/>

chrome/android/features/tab_ui/java/res/layout/bottom_tab_grid_toolbar.xml

@@ -25,8 +25,9 @@
             android:src="@drawable/ic_expand_more_black_24dp"
             app:tint="@color/default_icon_color_tint_list"
             android:contentDescription="@string/accessibility_bottom_tab_grid_close_tab_sheet" />
+        <!-- This generic option should not have autofillHints (crbug.com/1073966#c3). -->
         <EditText
-            tools:ignore="LabelFor"
+            tools:ignore="Autofill,LabelFor"
             android:id="@+id/title"
             android:cursorVisible="false"
             android:layout_height="@dimen/bottom_sheet_peek_height"

chrome/android/java/res/layout/password_entry_editor.xml

@@ -15,6 +15,8 @@
     android:paddingLeft="@dimen/password_entry_editor_content_spacing"
     android:paddingRight="@dimen/password_entry_editor_content_spacing">
 
+    <!-- Should not have autofillHints. See: https://crbug.com/1073966#c2 -->
+
     <!-- Site -->
     <com.google.android.material.textfield.TextInputLayout
         android:id="@+id/site_label"
@@ -25,7 +27,7 @@
         android:layout_marginBottom="@dimen/password_entry_editor_field_bottom_margin">
 
         <EditText
-            tools:ignore="LabelFor"
+            tools:ignore="Autofill,LabelFor"
             android:id="@+id/site_edit"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
@@ -45,7 +47,7 @@
         android:layout_marginBottom="@dimen/password_entry_editor_field_bottom_margin">
 
         <EditText
-            tools:ignore="LabelFor"
+            tools:ignore="Autofill,LabelFor"
             android:id="@+id/username_edit"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
@@ -71,7 +73,7 @@
             android:layout_marginBottom="@dimen/password_entry_editor_field_bottom_margin">
 
         <EditText
-            tools:ignore="LabelFor"
+            tools:ignore="Autofill,LabelFor"
             android:id="@+id/password_edit"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"

components/browser_ui/widget/android/java/res/layout/radio_button_with_edit_text.xml

@@ -19,7 +19,7 @@
 
     <!-- Hint will be added programmatically so we're ignoring the lint warning. -->
     <EditText
-        tools:ignore="LabelFor"
+        tools:ignore="Autofill,LabelFor"
         android:id="@+id/edit_text"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"