Commit ffc960a3 authored by Adenilson Cavalcanti's avatar Adenilson Cavalcanti Committed by Commit Bot

Enable compiler optimization in inflate_fast on ARM

Generate optimized code that will help ARMv8 chips (between 2
to 10% perf gain on ARMv8 little/big cores) at the expense of
a small perf regression on older chips (i.e. ARMv7).

Bug: 772870
Change-Id: Ifc47870724da9790c944f76fedcc225d0a896caf
Reviewed-on: https://chromium-review.googlesource.com/976521
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: default avatarChris Blume <cblume@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546016}
parent 36b8b8de
...@@ -152,13 +152,13 @@ source_set("zlib_inflate_chunk_simd") { ...@@ -152,13 +152,13 @@ source_set("zlib_inflate_chunk_simd") {
"contrib/optimizations/inflate.c", "contrib/optimizations/inflate.c",
] ]
# TODO(772870) back off from -O3 while investigating Android if (!is_debug) {
# One perf bot PNG decode regression. # Here we trade better performance on newer/bigger ARMv8 cores
# if (!is_debug) { # for less perf on ARMv7. For details, check:
# # Use optimize_speed (-O3) to output the _smallest_ code. # https://bugs.chromium.org/p/chromium/issues/detail?id=772870#c40
# configs -= [ "//build/config/compiler:default_optimization" ] configs -= [ "//build/config/compiler:default_optimization" ]
# configs += [ "//build/config/compiler:optimize_speed" ] configs += [ "//build/config/compiler:optimize_speed" ]
# } }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment