Commit ffd7b290 authored by cbentzel's avatar cbentzel Committed by Commit bot

Remove unowned http_cache_transaction histograms which accumulate backend storage cruft.

BUG=429300

Review URL: https://codereview.chromium.org/695073002

Cr-Commit-Position: refs/heads/master@{#302629}
parent 19f1a749
...@@ -215,23 +215,6 @@ void RecordOfflineStatus(int load_flags, RequestOfflineStatus status) { ...@@ -215,23 +215,6 @@ void RecordOfflineStatus(int load_flags, RequestOfflineStatus status) {
} }
} }
// TODO(rvargas): Remove once we get the data.
void RecordVaryHeaderHistogram(const net::HttpResponseInfo* response) {
enum VaryType {
VARY_NOT_PRESENT,
VARY_UA,
VARY_OTHER,
VARY_MAX
};
VaryType vary = VARY_NOT_PRESENT;
if (response->vary_data.is_valid()) {
vary = VARY_OTHER;
if (response->headers->HasHeaderValue("vary", "user-agent"))
vary = VARY_UA;
}
UMA_HISTOGRAM_ENUMERATION("HttpCache.Vary", vary, VARY_MAX);
}
void RecordNoStoreHeaderHistogram(int load_flags, void RecordNoStoreHeaderHistogram(int load_flags,
const net::HttpResponseInfo* response) { const net::HttpResponseInfo* response) {
if (load_flags & net::LOAD_MAIN_FRAME) { if (load_flags & net::LOAD_MAIN_FRAME) {
...@@ -1227,7 +1210,6 @@ int HttpCache::Transaction::DoSuccessfulSendRequest() { ...@@ -1227,7 +1210,6 @@ int HttpCache::Transaction::DoSuccessfulSendRequest() {
cache_->DoomMainEntryForUrl(request_->url); cache_->DoomMainEntryForUrl(request_->url);
} }
RecordVaryHeaderHistogram(new_response);
RecordNoStoreHeaderHistogram(request_->load_flags, new_response); RecordNoStoreHeaderHistogram(request_->load_flags, new_response);
if (new_response_->headers->response_code() == 416 && if (new_response_->headers->response_code() == 416 &&
...@@ -1361,10 +1343,7 @@ int HttpCache::Transaction::DoCreateEntryComplete(int result) { ...@@ -1361,10 +1343,7 @@ int HttpCache::Transaction::DoCreateEntryComplete(int result) {
return OK; return OK;
} }
if (result == OK) { if (result != OK) {
UMA_HISTOGRAM_BOOLEAN("HttpCache.OpenToCreateRace", false);
} else {
UMA_HISTOGRAM_BOOLEAN("HttpCache.OpenToCreateRace", true);
// We have a race here: Maybe we failed to open the entry and decided to // We have a race here: Maybe we failed to open the entry and decided to
// create one, but by the time we called create, another transaction already // create one, but by the time we called create, another transaction already
// created the entry. If we want to eliminate this issue, we need an atomic // created the entry. If we want to eliminate this issue, we need an atomic
......
...@@ -10193,6 +10193,9 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -10193,6 +10193,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram> </histogram>
<histogram name="HttpCache.Vary" enum="VaryType"> <histogram name="HttpCache.Vary" enum="VaryType">
<obsolete>
Deprecated as of 11/2014.
</obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner> <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>The type of Vary header for a given GET response.</summary> <summary>The type of Vary header for a given GET response.</summary>
</histogram> </histogram>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment