Skip to content

GitLab

T
tangled
Commit ffebd7dd authored by dmazzoni@chromium.org's avatar dmazzoni@chromium.org
Browse files
Options

Always return a subrole when the Mac accessibility role is AXList. 

We already had tests for <ul>, <ol>, and <dl>, but not for
<div role="list">, but it seems simplest to just always return a subrole
of AXContentList by default and AXDescriptionList only for <dl>, since
VoiceOver gets confused if it isn't one of those two.

BUG=373498

Review URL: https://codereview.chromium.org/284113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271239 0039d316-1c4b-4281-b951-d872f2087c98
parent 575b29d0
Hide whitespace changes
Inline Side-by-side
Showing with 29 additions and 4 deletions
content/browser/accessibility/browser_accessibility_cocoa.mm
View file @ ffebd7dd
...@@ -847,11 +847,10 @@ NSDictionary* attributeToMethodNameMap = nil; ...@@ -847,11 +847,10 @@ NSDictionary* attributeToMethodNameMap = nil;
browserAccessibility_, ui::AX_ATTR_HTML_TAG); browserAccessibility_, ui::AX_ATTR_HTML_TAG);
if (browserAccessibilityRole == ui::AX_ROLE_LIST) { if (browserAccessibilityRole == ui::AX_ROLE_LIST) {
if ([htmlTag isEqualToString:@"ul"] || if ([htmlTag isEqualToString:@"dl"]) {
[htmlTag isEqualToString:@"ol"]) {
return @"AXContentList";
} else if ([htmlTag isEqualToString:@"dl"]) {
return @"AXDescriptionList"; return @"AXDescriptionList";
} else {
return @"AXContentList";
} }
} }
......
content/browser/accessibility/dump_accessibility_tree_browsertest.cc
View file @ ffebd7dd
...@@ -297,6 +297,10 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaLevel) { ...@@ -297,6 +297,10 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaLevel) {
RunTest(FILE_PATH_LITERAL("aria-level.html")); RunTest(FILE_PATH_LITERAL("aria-level.html"));
} }
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaList) {
RunTest(FILE_PATH_LITERAL("aria-list.html"));
}
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaMenu) { IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaMenu) {
RunTest(FILE_PATH_LITERAL("aria-menu.html")); RunTest(FILE_PATH_LITERAL("aria-menu.html"));
} }
......
content/test/data/accessibility/aria-list-expected-mac.txt 0 → 100644
View file @ ffebd7dd
AXWebArea
AXList AXSubrole=AXContentList
AXGroup
AXStaticText AXValue='Item 1'
AXGroup
AXStaticText AXValue='Item 2'
AXGroup
AXStaticText AXValue='Item 3'
content/test/data/accessibility/aria-list.html 0 → 100644
View file @ ffebd7dd
<!--
@MAC-ALLOW:AXSubrole*
-->
<html>
<body>
<div role="list">
<div role="listitem">Item 1</div>
<div role="listitem">Item 2</div>
<div role="listitem">Item 3</div>
</div>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment