[iOS] Add more integration tests for Safe Browsing

This adds additional EG test coverage for Safe Browsing, for
scenarios identified by the test team when they were
manually testing this feature.

Change-Id: Id27ff75a0e92ba7501aeb250ab0112d8eb9a278b
Bug: 1093510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246995
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780509}

ios/chrome/browser/safe_browsing/BUILD.gn

@@ -106,6 +106,7 @@ source_set("eg2_tests") {
     "//base",
     "//components/safe_browsing/core:features",
     "//components/safe_browsing/core/common:safe_browsing_prefs",
+    "//components/strings:components_strings_grit",
     "//ios/chrome/test/earl_grey:eg_test_support+eg2",
     "//ios/testing/earl_grey:eg_test_support+eg2",
     "//ios/third_party/earl_grey2:test_lib",
@@ -113,6 +114,7 @@ source_set("eg2_tests") {
     "//ios/web/public/test:element_selector",
     "//ios/web/public/test/http_server",
     "//net:test_support",
+    "//ui/base",
   ]
   libs = [ "UIKit.framework" ]
 }

ios/chrome/browser/ui/settings/google_services/google_services_settings_egtest.mm

@@ -47,6 +47,25 @@ using chrome_test_util::SettingsDoneButton;
 
 @implementation GoogleServicesSettingsTestCase
 
+- (AppLaunchConfiguration)appConfigurationForTestCase {
+  AppLaunchConfiguration config;
+
+  // Features are enabled or disabled based on the name of the test that is
+  // running. This is done because it is inefficient to use
+  // ensureAppLaunchedWithConfiguration for each test.
+  if ([self isRunningTest:@selector(testToggleSafeBrowsing)] ||
+      [self isRunningTest:@selector
+            (testTogglePasswordLeakCheckWhenSafeBrowsingAvailable)]) {
+    config.features_enabled.push_back(
+        safe_browsing::kSafeBrowsingAvailableOnIOS);
+  } else if ([self isRunningTest:@selector
+                   (testTogglePasswordLeakCheckWhenSafeBrowsingNotAvailable)]) {
+    config.features_disabled.push_back(
+        safe_browsing::kSafeBrowsingAvailableOnIOS);
+  }
+  return config;
+}
+
 // Opens the Google services settings view, and closes it.
 - (void)testOpenGoogleServicesSettings {
   [self openGoogleServicesSettings];
@@ -164,14 +183,49 @@ using chrome_test_util::SettingsDoneButton;
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
 }
 
+// Tests that the Safe Browsing toggle reflects the current value of the
+// Safe Browsing preference, and updating the toggle also updates the
+// preference.
+- (void)testToggleSafeBrowsing {
+  // Start in the default (opted-in) state for Safe Browsing.
+  [ChromeEarlGrey setBoolValue:YES forUserPref:prefs::kSafeBrowsingEnabled];
+
+  [self openGoogleServicesSettings];
+
+  // Check that Safe Browsing is enabled, and toggle it off.
+  [[self elementInteractionWithGreyMatcher:
+             chrome_test_util::SettingsSwitchCell(
+                 kSafeBrowsingItemAccessibilityIdentifier,
+                 /*is_toggled_on=*/YES,
+                 /*enabled=*/YES)]
+      performAction:chrome_test_util::TurnSettingsSwitchOn(NO)];
+
+  // Check the underlying pref value.
+  GREYAssertFalse([ChromeEarlGrey userBooleanPref:prefs::kSafeBrowsingEnabled],
+                  @"Failed to toggle-off Safe Browsing");
+
+  // Close settings.
+  [[EarlGrey selectElementWithMatcher:SettingsDoneButton()]
+      performAction:grey_tap()];
+
+  // Open settings again, verify Safe Browsing is still disabled, and re-enable
+  // it.
+  [self openGoogleServicesSettings];
+  [[self elementInteractionWithGreyMatcher:
+             chrome_test_util::SettingsSwitchCell(
+                 kSafeBrowsingItemAccessibilityIdentifier,
+                 /*is_toggled_on=*/NO,
+                 /*enabled=*/YES)]
+      performAction:chrome_test_util::TurnSettingsSwitchOn(YES)];
+
+  // Check the underlying pref value.
+  GREYAssertTrue([ChromeEarlGrey userBooleanPref:prefs::kSafeBrowsingEnabled],
+                 @"Failed to toggle-on Safe Browsing");
+}
+
 // Tests that password leak detection can be toggled when Safe Browsing isn't
 // available.
 - (void)testTogglePasswordLeakCheckWhenSafeBrowsingNotAvailable {
-  AppLaunchConfiguration config;
-  config.features_disabled.push_back(
-      safe_browsing::kSafeBrowsingAvailableOnIOS);
-  [[AppLaunchManager sharedManager] ensureAppLaunchedWithConfiguration:config];
-
   // Ensure that Safe Browsing and password leak detection opt-outs start in
   // their default (opted-in) state.
   [ChromeEarlGrey setBoolValue:YES forUserPref:prefs::kSafeBrowsingEnabled];
@@ -232,10 +286,6 @@ using chrome_test_util::SettingsDoneButton;
 // Tests that when Safe Browsing is available, password leak detection can only
 // be toggled if Safe Browsing is enabled.
 - (void)testTogglePasswordLeakCheckWhenSafeBrowsingAvailable {
-  AppLaunchConfiguration config;
-  config.features_enabled.push_back(safe_browsing::kSafeBrowsingAvailableOnIOS);
-  [[AppLaunchManager sharedManager] ensureAppLaunchedWithConfiguration:config];
-
   // Ensure that Safe Browsing and password leak detection opt-outs start in
   // their default (opted-in) state.
   [ChromeEarlGrey setBoolValue:YES forUserPref:prefs::kSafeBrowsingEnabled];
@@ -393,4 +443,20 @@ using chrome_test_util::SettingsDoneButton;
                    IDS_IOS_GOOGLE_SERVICES_SETTINGS_BETTER_SEARCH_AND_BROWSING_DETAIL];
 }
 
+// Returns YES if the test method name extracted from |selector| matches the
+// name of the currently running test method.
+- (BOOL)isRunningTest:(SEL)selector {
+  return [[self currentTestMethodName] isEqual:NSStringFromSelector(selector)];
+}
+
+// Returns the method name, e.g. "testSomething" of the test that is currently
+// running. The name is extracted from the string for the test's name property,
+// e.g. "-[GoogleServicesSettingsTestCase testSomething]".
+- (NSString*)currentTestMethodName {
+  int testNameStart = [self.name rangeOfString:@"test"].location;
+  return [self.name
+      substringWithRange:NSMakeRange(testNameStart,
+                                     self.name.length - testNameStart - 1)];
+}
+
 @end